fixes and associated tests for SimulationParameters calculating
trading_days.