add the one logic
need to complete