update_phabricator fails to find and restart apache, hence upgrade (process) is never (db upgrade, phd launch, etc.) never completes.

I checked lsb_release, we might need to do more work (extract distro from string).

Thanks

-abdul

On 09-Feb-2013, at 2:43 AM, edwardspeyer <notifications@github.com> wrote:

> In scripts/install/update_phabricator.sh:
> 
> > +if [ "{$OS}" == "Darwin" ]; then
> > +    #OS=mac
> > +    HTTPD_START_COMMAND="sudo /usr/sbin/apachectl -k start"
> > +    HTTPD_STOP_COMMAND="sudo /usr/sbin/apachectl -k stop"
> > +else
> > +    if [ "${OS}" = "Linux" ] ; then
> > +        if [ -f /etc/redhat-release ] ; then
> > +            HTTPD_START_COMMAND="sudo /etc/init.d/httpd start"
> > +            HTTPD_STOP_COMMAND="sudo /etc/init.d/httpd  stop"
> > +        elif [ -f /etc/mandrake-release ] ; then
> > +            HTTPD_START_COMMAND="sudo /etc/init.d/httpd start"
> > +            HTTPD_STOP_COMMAND="sudo /etc/init.d/httpd  stop"
> > +        elif [ -f /etc/debian_version ] ; then
> > +            HTTPD_START_COMMAND="sudo /etc/init.d/apache2 start"
> > +            HTTPD_STOP_COMMAND="sudo /etc/init.d/apache2  stop"
> > +        elif [ -f /etc/debian_version ] ; then
> I haven't followed what the goal is here, but lsb_release --id and a case...esac statement is another way to achieve this.
> 
> —
> Reply to this email directly or view it on GitHub..
> 
>