I opened a task to replace this with ads sdk, but it won't be done this
sprint.
On Nov 4, 2013 3:25 PM, "Tucker DeWitt" <notifications@github.com> wrote:

> In bin/launch_emr.rb:
>
> > +      logger.warn options.to_s
> > +      exit 1
> > +    end
> > +    if !LOG_LEVELS.include?(settings.log_level)
> > +      logger.warn "Invalid log_level (#{settings.log_level}).  Valid values: #{LOG_LEVELS.join(', ')}"
> > +      exit 1
> > +    end
> > +  rescue OptionParser::InvalidOption, OptionParser::MissingArgument
> > +    logger.error $!.to_s
> > +    logger.error options.to_s
> > +    exit 1
> > +  end
> > +  settings
> > +end
> > +
> > +def allocate_emr_instance(settings, logger)
>
> You should be using the aws-sdk to do all of this. Not doing it is why you
> end up with all these really long lines. You're stringing together commands
> based on conditions and appending switches/values all of the place. The
> aws-sdk handles all of this:
>
> http://docs.aws.amazon.com/AWSRubySDK/latest/frames.html
>
> Relying on commands is inherently unsafe and doubly so when making the
> assumption that the command is in the user's PATH (as opposed to being
> explicit about location or requiring to user to provide that info).
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/AltiPub/perf-framework/pull/2/files#r7417523>
> .
>