Thanh discussed with me for now to just support metadata for ogg since
there is no real solution for webm. But at the time yes my idea was to have
different methods for different file types, since no library seems to
handle them all, I will add a docstring to clarify.
On Nov 20, 2013 8:12 PM, "Dennis Ideler" <notifications@github.com> wrote:

> In src/freeseer/framework/youtube.py:
>
> > +    config.readfp(open(configfile))
> > +    return config.get('Global', 'video_directory') + "/"
> > +
> > +
> > +def escape(s):
> > +    # Escape a filepath (not always required but can be needed with certain
> > +    # system functions)
> > +    return "'" + s.replace("'", "'\\''") + "'"
> > +
> > +
> > +def valid_video_file(file):
> > +    # Freeseer currently encodes to .ogg and .webm
> > +    return file.lower().endswith(('.ogg', '.webm'))
> > +
> > +
> > +def get_metadata(video_file):
>
> Without a docstring, it's difficult to see the point of this method since
> it just calls another method right away, making it kinda useless. Is the
> idea to have different ways of getting the metadata? E.g.
>
> def get_metadata(video_filepath):
>     if filetype is ogg
>         return get_metadata_from_mutagen(video_filepath)
>     if filetype is ...
>         return get_metadata_from_foo(video_filepath)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Freeseer/freeseer/pull/402/files#r7812682>
> .
>