Hi Victor,

A callback makes sense. Should that be a global call back or a per-packet callback?

Regards,
-Ken

From: Victor Julien [mailto:notifications@github.com]
Sent: Tuesday, June 25, 2013 8:48 AM
To: inliniac/suricata
Cc: Kenneth Steele
Subject: Re: [suricata] Initial Tile mPIPE support (#403)


In src/tmqh-packetpool.c:

> @@ -270,8 +275,15 @@ void TmqhOutputPacketpool(ThreadVars *t, Packet *p)

>              SCFree(p->root);

>              p->root = NULL;

>          } else {

> -            PACKET_RECYCLE(p->root);

> -            RingBufferMrMwPut(ringbuffer, (void *)p->root);

> +#ifdef HAVE_MPIPE

I would like to solve this differently as I don't like to have mpipe specific code here. I think introducing a callback that is invoked here would make sense.

—
Reply to this email directly or view it on GitHub<https://github.com/inliniac/suricata/pull/403/files#r4864790>.