I've changed that in my next branch; pull request to follow.

Sent from my iPhone

On 25 Jan 2013, at 15:13, ahgittin <notifications@github.com> wrote:

> In core/src/main/java/brooklyn/util/internal/ssh/SshAbstractTool.java:
> 
> > @@ -87,7 +87,12 @@ protected static void warnOnDeprecated(Map<String, ?> props, String deprecatedKe
> >          protected File localTempDir = new File(System.getProperty("java.io.tmpdir"), "tmpssh");
> >  
> >          @SuppressWarnings("unchecked")
> > -        public AbstractToolBuilder<T> from(Map<String,?> props) {
> > +        protected B self() {
> > +           return (B) this;
> > +        }
> > +
> > +        @SuppressWarnings("unchecked")
> > +        public B from(Map<String,?> props) {
> >              host = getMandatoryVal(props, "host", String.class);
> this (Builder.from) should be using the config keys in this class (not the deprecated methods),
> ie
> 
> host = getMandatoryValue(props, PROPS_HOST)
> i thought i had done this but maybe lost it on the merge.
> 
> --a
> 
> —
> Reply to this email directly or view it on GitHub.
>