it could be in common so far. actually it should be in some kind of
VmdkBaseBuilder, or included in some module called VmdkSupport.


On Wed, Feb 6, 2013 at 11:03 AM, Ankur Chauhan <notifications@github.com>wrote:

> In lib/stemcell/builders/centos.rb:
>
> > @@ -17,6 +17,21 @@ module Bosh::Agent::StemCell
> >    # }
> >    class CentosBuilder < BaseBuilder
> >
> > +    def generate_image
> > +      # FIXME: This should be common for all the vmdk based builder
> > +      #        Refactor me later!
> > +
> > +      Dir.chdir(@prefix) do
>
> Shouldn't we just push this as the default implementation? Why have the
> default do a touch if this code is common?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/ankurcha/stemcell/pull/2/files#r2904595>.
>
>



-- 
Best Regards,
Yongkun