Get rid of deprecated API usage
Fix maybe possible DoS by infinite redirect loop:
- This applies what https://github.com/freenet/plugin-WoT-staging/commit/4f2c9a7839a236947ddfb01653ae541da898cd1a did for GET to POST as well
-  I am not certain about whether an infinite redirect loop would be possible with POST since the redirect will probably redirect to GET. But its a good idea to have such a check anyway.
Eliminate code duplication
Eliminiate code duplication
Terminate the session if the logged in identity is gone
Satisfy the compiler
Reduce line count
Document & complete session management code of WebInterfaceToadlet:
- We did only provide code for peeking whether a session exists, not for using it => This commit adds a function for using it and obtaining the user ID.
- The following commits will wire in that function to the rest of the web interface
Provide the OwnIdentity ID in WebPageImpl:
- Require a boolean in the constructor which tells whether the child WebPage class needs to obtain the user ID or not.
- Adapt all WebPage classes to use it
Add some more guarding against infinite redirect loop DoS.
Use default parameter instead of manually implementing defaulting
Fix identity creation & clean it up:
- Fix CreateIdentityPage to be self-contained by adding the missing nickname input. This fixes identity creation not working from the LogInPage
- Don't inline identity creation controls on OwnIdentitiesPage, only link to CreateIdentityPage
- Move all code & l10n for generating the identity creation UI to CreateIdentityPage
- This fixes bug https://bugs.freenetproject.org/view.php?id=6068
Add FIXME
Store the Toadlet and the Context in WebPageImpl
Fix misusage of infoboxes:
- Do not add content to the outer of the infobox, add it to its content node.
- Add the outer of the infobox to the page
- This fixes issue https://bugs.freenetproject.org/view.php?id=6070
Fix layout mixup
Add code for logout to WebInterfaceToadlet:
- Used in LogOutWebInterfaceToadlet only currently.
- Will be used for logging out the user if he deletes his identity or creates a new one.
Log out the user when creating / deleting an identity:
- Add the log in page to the bottom of the page which shows the "Identity created" / "Identity page" deleted message
- This improves the WebPageImpl base class: It now allows adding one page to another page
- Get rid of storing infoboxes in an array and adding them in toHTML(), instead add them immediately
- I have tested all infobox functions, they seem to work.
- Of course I've also tested the log out functionality & page adding
Don't generate the LogInPage manually, let the Toadlet do it - thats what we have it for
Don't pass around the BaseL10n to WebPage constructors:
- We won't need specific translations for certain pages so we can just let them pull it from the WebInterface