Just to make sure, I finished this in a new PR that include the commit in
this PR.

thanks


On Mon, Dec 16, 2013 at 9:35 PM, David Warde-Farley <
notifications@github.com> wrote:

> In
> pylearn2/packaged_dependencies/theano_linear/unshared_conv/gpu_unshared_conv.py:
>
> > @@ -769,7 +769,7 @@ def c_code(self, node, nodename, inames, onames, sub):
> >
> >
> >  @register_opt()
> > -@local_optimizer([])
> > +@local_optimizer(None)
>
> What I mean is that the function being decorated contains some code to
> make sure that it is running on the right op. e.g. `if isinstance(node.op,
> CrossMapNormUndo)`... If we are telling Theano to only run it on these ops
> anyway, this extra code is unnecessary, right?
> … <#142fe68dee3816f5_>
> On Mon, Dec 16, 2013 at 9:28 PM, Frédéric Bastien <
> notifications@github.com> wrote: In
> pylearn2/packaged_dependencies/theano_linear/unshared_conv/gpu_unshared_conv.py:
> > @@ -769,7 +769,7 @@ def c_code(self, node, nodename, inames, onames,
> sub): > > > @register_opt() > -@local_optimizer([]) >
> +@local_optimizer(None) This is to make Theano optimization faster. Now the
> EquilibriumOptimizer don't try all opt on all node. It only run opt that
> have a chance of doing something. But your sentence wasn't complete. Did
> you mean something else? Fred … On Mon, Dec 16, 2013 at 9:06 PM, David
> Warde-Farley < notifications@github.com> wrote: In
> pylearn2/packaged_dependencies/theano_linear/unshared_conv/gpu_unshared_conv.py:
> > @@ -769,7 +769,7 @@ def c_code(self, node, nodename, inames, onames,
> sub): > > > @register_opt() > -@local_optimizer([]) >
> +@local_optimizer(None) @nouiz <https://github.com/nouiz> <
> https://github.com/nouiz> Am I right in thinking that we can remove the
> op-identity checking logic from the optimizer function with this new
> interface? It's not much of a computation saving but it's something. …
> <#142fe4de8c4435ef_> On Mon, Dec 16, 2013 at 9:04 PM, Frédéric Bastien <
> notifications@github.com>wrote: > In >
> pylearn2/packaged_dependencies/theano_linear/unshared_conv/gpu_unshared_conv.py:
> > > > @@ -769,7 +769,7 @@ def c_code(self, node, nodename, inames, onames,
> sub): > > > > > > @register_opt() > > -@local_optimizer([]) > >
> +@local_optimizer(None) > > PL is right, but it should be a list like:
> @local_optimizer([ImgActs]) > … <#142fe4c701b602ef_> > On Mon, Dec 16, 2013
> at 6:37 PM, Pascal Lamblin <notifications@github.com>wrote: In
> pylearn2/packaged_dependencies/theano_linear/unshared_conv/gpu_unshared_conv.py:
> > @@ -769,7 +769,7 @@ def c_code(self, node, nodename, inames, onames,
> sub): > > > @register_opt() > -@local_optimizer([]) >
> +@local_optimizer(None) And this one should be @local_optimizer(ImgActs) —
> Reply to this email directly or view it on GitHub<
> https://github.com/lisa-lab/pylearn2/pull/492/files#r8387095> . — Reply
> to this email directly or view it on GitHub<
> https://github.com/lisa-lab/pylearn2/pull/492/files#r8390613> . — Reply
> to this email directly or view it on GitHub<
> https://github.com/lisa-lab/pylearn2/pull/492/files#r8390641> . — Reply
> to this email directly or view it on GitHub.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/lisa-lab/pylearn2/pull/492/files#r8391147>
> .
>