i want this more generic than my test