have write some unit tests