Where's the @istest decorator? This breaks the convention we're using for test cases.

Something you can think of, when deciding for a test case name, as we're using object-oriented programming a lot in this project is: think of the class as an object in real life, and think of a method as a behaviour; Following this, you can think that "some object" "does something". For example: the "Role" (RoleTest) "converts a script" (@istest converts_script(self)). This is why using the @istest decorator is nice: because it doesn't get into the way of the test case name, so you can read it as a behaviour for that object.

If you have some free time, I'd recommend this reading, it's a really awesome book on the subject:
http://www.growing-object-oriented-software.com/