Hi Ermal:

 

I posted some feedback to your comments in the Github Pull Request thread, but upon further reflection I want to amend some of them and essentially agree with you on pretty much all your points.  The easiest approach, I think, is for me to close that original Pull Request myself and then issue a new one with a fresh set of cleaned up commits.  I will do that this evening.  I believe it will make for a less confusing package with fewer commits (some of which undo stuff in previous ones).

 

I will remove the Snort restart code I had added to the Preprocessors, Categories and Interface Edit tabs.  I also renamed that log file name variable and made the other changes you suggested.  I will be adding a different approach in one area with regards to restarting Snort after the automatic rule updates.  I added code that allows selectively "soft restarting" a given interface using the new reload feature in Snort.  This will hopefully make rule updates less trouble since the SIGHUP sent to each running Snort process will cause it to read the new rules and seamlessly update.  To cope with the fact Barnyard2 currently has no "soft restart" equivalent, the same Snort soft-restart code will cycle Barnyard2 (if running) so it can pick up any changes sid-msg.map or gen-msg.map files.  The only place I call this soft restart routine for now is from the automatic rules update code, but I put the routine in the snort.inc file to make it easier to call from other places in the future.

 

 

Bill Meeks

Vidalia, GA  30474

(912) 537-1091

 

From: Ermal Luçi [mailto:notifications@github.com] 
Sent: Sunday, April 07, 2013 4:06 PM
To: pfsense/pfsense-packages
Cc: Bill Meeks
Subject: Re: [pfsense-packages] Snort GUI Pkg Update to 2.5.5 - Bug Fixes, Stability and New Features (#421)

 

In pkg_config.8.xml:

> @@ -511,7 +511,7 @@
>              <!-- Use both styles for now, since our snort port isn't yet optionsng, but barnyard2 and others are. -->
>              <build_options>barnyard2_UNSET=ODBC PGSQL PRELUDE;barnyard2_SET=GRE IPV6 MPLS MYSQL;snort_UNSET=TARGETBASED PERFPROFILE REACT;snort_SET=DECODERPRE FLEXRESP3 GRE IPV6 MPLS NORMALIZER ZLIB;perl_SET=THREADS;WITH_THREADS=yes;WITH_IPV6=true;WITH_MPLS=true;WITH_GRE=true;WITHOUT_TARGETBASED=true;WITH_DECODERPRE=true;WITH_ZLIB=true;WITH_NORMALIZER=true;WITHOUT_REACT=true;WITH_FLEXRESP3=true;WITHOUT_ODBC=true;WITHOUT_POSTGRESQL=true;WITHOUT_PRELUDE=true;NOPORTDOCS=true</build_options>
>               <config_file>http://www.pfsense.com/packages/config/snort/snort.xml <http://www.pfsense.com/packages/config/snort/snort.xml%3c/config_file> </config_file>
> -            <version>2.9.4.1 pkg v. 2.5.4</version>
> +            <version>2.9.4.1 pkg v. 2.5.5</version>

Probably you should add here the new file you create above os it gets copied during install

—
Reply to this email directly or view it on GitHub <https://github.com/pfsense/pfsense-packages/pull/421/files#r3687196> .  <https://github.com/notifications/beacon/R-JShtnbK5EIHjDbYnegTXSgVZk0P0y0q153fmtFJ9Ckr_-lhYTpIULthmkx8nuE.gif>