Thanks for all the feedback.  I think I have addressed most of your points
now and pushed them to my master.

Kerby


On Sat, Jun 29, 2013 at 11:50 PM, Josef Perktold
<notifications@github.com>wrote:

> In statsmodels/genmod/generalized_estimating_equations.py:
>
> > +        return self.params / self.standard_errors
> > +
> > +
> > +    @cache_readonly
> > +    def pvalues(self):
> > +        dist = stats.norm
> > +        return 2*dist.cdf(-np.abs(self.tvalues))
> > +
> > +
> > +    @cache_readonly
> > +    def resid(self):
> > +        R = [y - np.dot(x, self.params) for x,y in zip(self.model.X, self.model.Y)]
> > +        return R
> > +
> > +
> > +    def predict(self, exog=None, link=False):
>
> The pattern we have in the other models is to put predict with additional
> params argument in the Model not the Results class.
>
> predict in results can be inherited from base.model.Model which includes
> formula handling for prediction
> (I haven't looked at predict in details since it includes formulas)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/statsmodels/statsmodels/pull/928/files#r4953404>
> .
>