Maybe skip the `char *` example for this PR?


On Sat, Dec 28, 2013 at 7:24 AM, Paul Kehrer <notifications@github.com>wrote:

> In docs/contributing.rst:
>
> > +Values set by #define should be assigned the appropriate type. If you see
> > +this:
> > +
> > +.. code-block:: c
> > +
> > +    #define SOME_INTEGER 0x0;
> > +    #define SOME_UINTEGER (unsigned int)0x0001;
> > +    #define SOME_STRING "hello";
> > +
> > +...it should be added to the bindings like so:
> > +
> > +.. code-block:: c
> > +
> > +    static const int SOME_INTEGER;
> > +    static const unsigned int SOME_UINTEGER;
> > +    static char *const SOME_STRING;
>
> So should we change the declaration here to "static const char*
> SOME_STRING"? If we do that then we'll also want to change the one place
> we're actually doing this (opensslv.py)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/pyca/cryptography/pull/361/files#r8576476>
> .
>



-- 
"I disapprove of what you say, but I will defend to the death your right to
say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
"The people's good is the highest law." -- Cicero
GPG Key fingerprint: 125F 5C67 DFE9 4084