The plan is to expose this to end users so I want to restrict access as much as possible. I'll make the setters private and add appropriate methods

Sent from my iPhone

> On 9 nov 2013, at 06:25, Simon Cropp <notifications@github.com> wrote:
> 
> In src/NServiceBus.Core/Unicast/SendOptions.cs:
> 
> > +            }
> > +        }
> > +        public SendOptions(Address destination):this()
> > +        {
> > +            Intent = MessageIntentEnum.Send;
> > +            this.destination = destination;
> > +            
> > +        }
> > +
> > +        public SendOptions(string destination): this(Address.Parse(destination))
> > +        {
> > +        }
> > +
> > +        public MessageIntentEnum Intent { get; set; }
> > +        public Address Destination { get { return destination; } }
> > +        public string CorrelationId { get; set; }
> i know i am being picky but there is really no point in encapsulating properties on an internal class. Since everything using it will be rebuild every time we build converting it to a property in the future is not a breaking change. These could really just be internal fields
> 
> —
> Reply to this email directly or view it on GitHub.