Removed the cursor position from being written to the pcb file.

Signed-off-by: Bert Timmerman <bert.timmerman@xs4all.nl>
parse_y.y: As of November 2012 the cursor position is not written to file anymore

Signed-off-by: Bert Timmerman <bert.timmerman@xs4all.nl>
Remove unused zoom settings from the PCB and settings data-structures
Remove unused prototypes SetZoom and RedrawZoom, along with old #ifdef'd code

SetZoom() was removed in commit 94e927e03850bfc0e8a0f3b161ae99b6784747f0

There were a few references to SetZoom left under an #ifdef HAVE_LIBSTROKE,
which will not work, so I have commented those as well.
Remove unused references to SwitchDrawingWindow()
Convert argument in HID_Flags to (void *) rather than (int)

void * allows us to pass pointers on all platforms, 64bit or
otherwise. We can still use casting macros to safely pass integer
values via this pointer.

Avoids the ugliness of castnig a size_t sized offset_of value into
an int. Due to the size of our structures, this did not cause any
actual bugs, but was not good practice.
Convert mask type to enum
hid/gcode: Make gcode_hid structure static
HID: Move non-PCB specific drawing calls into a separate API
Stop "find connected" following rat-lines. Fixes confusing output.

Suppose we have two nets, A and B, and some components. If we connect
a pin of a component which was supposed to be connected to net A, to
net B, the "f" (find connected) action will falsely show the entirity
of net A and net B connected to each other. In reality, the nets are
not electrically connected, it is just the ratline between the
mis-connected component pin (mis-connected to Net B), and net A,
where the ratline for that pin should end up.

It MIGHT be better if we fix this bug by not adding rat-lines to shorted
connections, as often those rat-lines would take some convoluted route
through the copper of the net which is shorted to that connection
end-point. These rat-line(s) would no longer be spatially associated
with the mis-connected wiring, and encourage the user to further short
net A and net B together to complete the ratline.

This bug was a contributing factor to a mistake in a production board
I made recently, where as a last step in production, I added a star-
ground short between two different ground planes (analogue and digital).
The "find connected" action, "f" showed them connected together (as I
expected), but unfortunately, due to a thermal I left out, they were not
actually connected - despite PCB's green rendering suggesting that they
were.
configure.ac: fixed a typo.

Signed-off-by: Bert Timmerman <bert.timmerman@xs4all.nl>
lesstif: corrections on recent HID API changes.

Reported by Eugene Mikhantiev <mikhantiev@gmail.com>

PCB can not be built with `--with-gui=lesstif' due to the
HID API changes in commit 73b243d90cda84e09f52b7ff995fa82afdc3de0

Signed-off-by: Bert Timmerman <bert.timmerman@xs4all.nl>
Make lesstif_hid struct static again

Changed to non-static un-necessarily in commit
a1d8ee04cc571cca4cbe7ef86b40bef612a0c387
draw.c: Add gc parameter to _draw_line() function

Avoid it assuming the correct GC is Output.fgGC
draw.c: Add hidGC parameter to DrawTextLowLevel() function

Avoid it assuming the correct gc to use is Output.fgGC
hid/batch: Fix build after splitting out graphics APIs

I forgot this one, along with build-testing lesstif - oops.

Fixes breakage from commit 273b243d90cda84e09f52b7ff995fa82afdc3de0
           and from commit 741f203565ba9f92b0ace80d858073f75ced2716
hid/lpr: Don't initiialise the graphics API vtable

Just being picky here..

I spent ages trying to work out why the old code didn't segfault, given
it does not call common_draw_helpers_init() to setup the various pad,
pin and polygon drawing routines.

It turns out that when we actually go to export, we call into the ps HID
directly - and ignore the lpr.c HID vtables.

Lets avoid confusion by partly setting up the lpr vtables, and leave the
graphics HID member as NULL.
autoroute.c: Destroy debug graphics context when we're finished with it

I caught this one by inspection, as we don't tend to build with autorouter
debugging enabled. I tested quickly before comitting, and this change
doesn't break anything. This said, I couldn't see any debug rendering
output either (before or after this patch).. so that might be broken
somewhere.
HID: Merge {fill/thindraw}_pcb_* APIs into HID_DRAW_API structure

I wanted to keep these separate from the pure graphics APIs, but
after poking at this more and more, it seems hard to justify why
we should do that.
Revert moving common_draw_helpers_init() call in lesstif and GTK HIDs

Not a functional change.. I'm just being anal and wishing to keep these
matching the other HIDs.