collection logics completed and tested