Yeah I wondered about that...


On Wed, Dec 18, 2013 at 10:57 AM, Adam Darrah <notifications@github.com>wrote:

> In lib/zero_fill.rb:
>
> > @@ -0,0 +1,102 @@
> > +require "date"
>
> Since almost every method in this class checks if hash? before doing
> anything and immediately splits into two branches, you should look into
> splitting this into multiple classes (possibly a base with your common
> logic, and an Array and Hash subclass). I think it would simplify things
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mobi/zerofill/pull/1/files#r8440071>
> .
>