agreed. I'll just make a ticket.

Matthew Gidden
Nuclear Energy University Programs Fellow
The University of Wisconsin -- Madison
Ph. 225.892.3192
Fax 608.263.7451


On Thu, Jun 6, 2013 at 12:00 PM, Robert Carlsen <notifications@github.com>wrote:

> In src/Core/Utility/LMatrix.cpp:
>
> > @@ -207,10 +194,10 @@ void LMatrix::print() const {
> >          // sums the product of the row vector from A and the column vector
> >          // from B using the formula aij = ai1*b1j + ai2*b2j + ...
> >          for (int k = 0; k < rows_; k++) {
> > -          aij = aij + M_.at(i).at(k) * rhs(k+1,j+1);
> > +          aij = aij + M_[i][k] * rhs.M_[k][j];
>
> I'm all for making more "improvements" to readability and changing to
> zero-indexing, but those won't speed things up. Changing the indexing will
> require changing code in the DecayHandler carefully. The purpose of this
> pull request was to change LMatrix as little as possible while making it
> faster. I'd prefer that further changes be in a separate pull request.
> … <#13f1a6f287b7c61d_>
> On Thu, Jun 6, 2013 at 11:34 AM, gidden <notifications@github.com> wrote:
> In src/Core/Utility/LMatrix.cpp: > @@ -207,10 +194,10 @@ void
> LMatrix::print() const { > // sums the product of the row vector from A and
> the column vector > // from B using the formula aij = ai1*b1j + ai2*b2j +
> ... > for (int k = 0; k < rows_; k++) { > - aij = aij + M_.at(i).at(k) *
> rhs(k+1,j+1); > + aij = aij + M_[i][k] * rhs.M_[k][j]; aij += ? — Reply to
> this email directly or view it on GitHub<
> https://github.com/cyclus/cyclus/pull/489/files#r4571594> .
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/cyclus/cyclus/pull/489/files#r4572140>
> .
>