Yes, that's no good. But I prefer it for the simple case. 

On Jun 19, 2013, at 15:41, Marek <notifications@github.com> wrote:

> In lib/assets/javascripts/turbolinks.js.coffee:
> 
> >  
> > -    if doc = validateResponse()
> In this case that can be done, if you wish.
> But in general I have the oposite opinion on inline assigments in conditions, because then someone may try write something like this:
> else if invalidContent() or assetsChanged (doc = createDocument xhr.responseText) 
> (fully: https://github.com/rails/turbolinks/blob/master/lib/assets/javascripts/turbolinks.js.coffee#L170-L174)
> which literally hurts
> 
> —
> Reply to this email directly or view it on GitHub.