Do not use ephemeral memory when adding a new data source

svn path=/trunk/; revision=51423
Do not use ephemeral memory when adding a new data source

svn path=/trunk/; revision=51424
Change some dissectors to use pinfo memory pool instead of malloc if it can trigger an exception between between buffer allocation and tvb_set_free_cb call

svn path=/trunk/; revision=51427
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9053 :
Update DDS RTPS Vendor and Product Ids based on http://portals.omg.org/dds/content/page/dds-rtps-vendor-and-product-ids

svn path=/trunk/; revision=51428
Gather together dedicated DRX configuration, and make sure that it
is internally consistent.

TODO: include r11 sequence that can overwrite some of these values.
TODO: actx->private_data gets reused for several purposes, need to
separate these uses out and avoid possible conflicts...

svn path=/trunk/; revision=51429
Fix Coverity CID 1063335: Unused pointer value.

svn path=/trunk/; revision=51430
Someone is bound to miss these expert info items, so add back expert info items for ack and urgent pointer when their respective flags are not set; however, don't indicate "Broken TCP" and only add them as Notes rather than as Warnings as was previously the case prior to r51356 since nowhere does it indicate these fields must be zero when their respective bits aren't set.

Speaking of r51356, a clarification to its commit message is in order: Initially my intention was to only add the urgent pointer field when the URG bit was set; however, I then noticed that the acknowledgment number field was always being added irrespective of the ACK bit.  Had I made the change as I originally intended, it would have introduced an inconsistency.  After some deliberation, I opted for consistency, but botched the commit message.

svn path=/trunk/; revision=51431
When using relative sequence numbers, don't scale acknowledgment numbers unless the ACK bit is actually set; otherwise doing so results in many erroneous packets matching a filter such as, "(tcp.ack > 0) && (tcp.flags.ack == 0)".  With this change, the number of expert infos noting non-zero acknowledgment numbers when the ACK bit is not set is the same as the number of packets that are displayed when applying the above display filter regardless of whether using relative or absolute sequence numbers.  (Tested using the menagerie's mond.pcap file)

svn path=/trunk/; revision=51432
Another acknowledgment number tweak: If the ACK flag wasn't set such that the base_seq wasn't subtracted from it, then if we need to recover absolute values later on, don't add the base_seq value back either.

svn path=/trunk/; revision=51433
Add a valgrind suppressions file set to suppress the zlib error which otherwise
pops up immediately on the fuzzbot. Hopefully there won't be too many more of
these.

svn path=/trunk/; revision=51434
From Tommy Wu:
Update Octet 7 of Indication IE.

svn path=/trunk/; revision=51435
Use g_hash_table() for ipxnet name resolution.

svn path=/trunk/; revision=51436
Mark an unused parameter.

svn path=/trunk/; revision=51437
Fix for 
[  6%] Building C object epan/CMakeFiles/epan.dir/addr_resolv.c.o
/home/jmayer/work/wireshark/svn/trunk/epan/addr_resolv.c:1927:1: error: unused function
      'get_ipxnetbyname' [-Werror,-Wunused-function]
get_ipxnetbyname(const gchar *name)
^
/home/jmayer/work/wireshark/svn/trunk/epan/addr_resolv.c:2009:1: error: unused function
      'add_ipxnet_name' [-Werror,-Wunused-function]

by #if 0/#endif the functions. If they really are not needed any more
they should be removed.

svn path=/trunk/; revision=51438
Fix several instances of clang warnings: Value stored to 'length' is never read
Also, whitespace changes (tabs ->spaces, indentation) and add modelines.

svn path=/trunk/; revision=51439
Fix clang warning: Value stored to 'netl' is never read.
Other misc. whitespace changes.

svn path=/trunk/; revision=51440
Fix clang warnings: Value stored to '[decrypted_]offset' is never read.

svn path=/trunk/; revision=51441
Fix clang warnings: Value stored to '[offset|length]' is never read.

svn path=/trunk/; revision=51442
If packet was modified fallback to generic clone

svn path=/trunk/; revision=51443
Composite tvb (tvb_memcpy/tvb_get_ptr): don't assert with offset == tvb->length, and 0 length

svn path=/trunk/; revision=51444