The javadoc on toHtmlSummary is:
 * Renders an HTML-formatted summary view of the custom value, that does
not take a lot of space. (This is
 * subjective, but generally means < 100 characters in length, or an image
of < 200 pixels in each dimension.)
 * This method should return quickly, e.g. in case we're rendering
thousands of custom values in a table.

So basically, yes, it is appropriate for this to be the name (with no
description).


On Fri, Oct 25, 2013 at 11:21 AM, wluyima <notifications@github.com> wrote:

> In
> web/src/main/java/org/openmrs/web/attribute/handler/BaseMetadataFieldGenDatatypeHandler.java:
>
> > +
> > +/**
> > + * This is a superclass for custom datatypes for metadata
> > + *
> > + * @since 1.10
> > + */
> > +public abstract class BaseMetadataFieldGenDatatypeHandler<T extends OpenmrsMetadata> implements FieldGenDatatypeHandler<SerializingCustomDatatype<T>, T> {
> > +	
> > +	/**
> > +	 * @see org.openmrs.web.attribute.handler.HtmlDisplayableDatatypeHandler#toHtmlSummary(org.openmrs.customdatatype.CustomDatatype,
> > +	 *      java.lang.String)
> > +	 */
> > +	@Override
> > +	public CustomDatatype.Summary toHtmlSummary(CustomDatatype<T> datatype, String valueReference) {
> > +		SerializingCustomDatatype<T> dt = (SerializingCustomDatatype<T>) datatype;
> > +		return new CustomDatatype.Summary(dt.deserialize(valueReference).getName(), true);
>
> @djazayeri <https://github.com/djazayeri> would you consider this to be
> the complete HTML summary? Or complete will include the description?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/openmrs/openmrs-core/pull/399/files#r7223969>
> .
>