you're right ! I'll handle all these changes today! thank you so much for
the code review!!


On Tue, Dec 10, 2013 at 1:57 AM, Jag Talon <notifications@github.com> wrote:

> In lib/DDG/Spice/Kwixer.pm:
>
> > +
> > +spice to => 'https://kwixer.com/api/watching/movie/explore?take=20&skip=0&query=$1';
> > +spice wrap_jsonp_callback => 1;
> > +
> > +my @triggers = ('movie' ,'movie with',  'movies', 'movies with', 'movies starring','film with','films with','films starring','film starring',
> > +	'movies directed by','movies directed', 'directed movies', 'director','film director','film by',
> > +	'actor','actress' ,
> > +	'kwixer');
> > +triggers start => @triggers;
> > +triggers end => ('actor','actress','movies','films','movie','film');
> > +handle remainder => sub {
> > +	# deliminater logic from Movie.pm
> > +    #my $input = $_;
> > +    #map { return $input if $input =~ s/(^|\s)$_(\s|$)// and $input ne '' } @triggers;
> > +    #return;
> > +  	return "$_" if $_;
>
> Also, why wrap the variable in double quotes?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/duckduckgo/zeroclickinfo-spice/pull/350/files#r8223773>
> .
>



-- 
-- 
Best Regards,
Rodrigue H.
http://www.twitter.com/rodrigue_
http://www.rodrigueh.com