Web Inspector: Inspected page sometimes crashes in InspectorResourceAgent::didFailLoading
https://bugs.webkit.org/show_bug.cgi?id=67193

Reviewed by Pavel Feldman.

* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didFailLoading):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94078 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Update registerProtocolHandler scheme whitelist to match spec
https://bugs.webkit.org/show_bug.cgi?id=67104

Patch by Ben Wells <benwells@chromium.org> on 2011-08-30
Reviewed by Darin Adler.

Source/WebCore:

* page/Navigator.cpp:
(WebCore::initProtocolHandlerWhitelist):

LayoutTests:

* fast/dom/register-protocol-handler-expected.txt:
* fast/dom/register-protocol-handler.html:
* platform/chromium/fast/dom/register-protocol-handler-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94079 268f45cc-cd09-0410-ab3c-d52691b4dbfc
The unused ScrollView* argument can and should be removed from
scrollRectIntoView.
https://bugs.webkit.org/show_bug.cgi?id=67117

Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2011-08-30
Reviewed by Darin Adler.

Source/WebCore:

* loader/EmptyClients.h:
(WebCore::EmptyChromeClient::scrollRectIntoView):
* page/Chrome.cpp:
(WebCore::Chrome::scrollRectIntoView):
* page/ChromeClient.h:
(WebCore::ChromeClient::scrollRectIntoView):

Source/WebKit/chromium:

* src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::scrollRectIntoView):
* src/WebPopupMenuImpl.h:

Source/WebKit/efl:

* WebCoreSupport/ChromeClientEfl.h:
(WebCore::ChromeClientEfl::scrollRectIntoView):

Source/WebKit/gtk:

* WebCoreSupport/ChromeClientGtk.h:
(WebKit::ChromeClient::scrollRectIntoView):

Source/WebKit/haiku:

* WebCoreSupport/ChromeClientHaiku.cpp:
(WebCore::ChromeClientHaiku::scrollRectIntoView):

Source/WebKit/mac:

* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::scrollRectIntoView):

Source/WebKit/qt:

* WebCoreSupport/ChromeClientQt.h:
(WebCore::ChromeClientQt::scrollRectIntoView):

Source/WebKit/win:

* WebCoreSupport/WebChromeClient.h:
(WebChromeClient::scrollRectIntoView):

Source/WebKit/wince:

* WebCoreSupport/ChromeClientWinCE.h:

Source/WebKit/wx:

* WebKitSupport/ChromeClientWx.h:
(WebCore::ChromeClientWx::scrollRectIntoView):

Source/WebKit2:

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::scrollRectIntoView):
* WebProcess/WebCoreSupport/WebChromeClient.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94080 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt][WK2] svg/animations/animate-end-attribute.html r93949
https://bugs.webkit.org/show_bug.cgi?id=67130

Skip a svg test on WebKit2 that rely on unimplemented test harness API.

Patch by Young Han Lee <joybro@company100.net> on 2011-08-30
Reviewed by Noam Rosenthal.

* platform/wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94081 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove webcore_bindings (including DerivedSources##.cpp) from the critical path
https://bugs.webkit.org/show_bug.cgi?id=67168

Reviewed by Adam Barth.

webcore_bindings_sources generates various files (e.g., CSSPropertyNames,
DerivedSources, HTMLNames, etc).  webcore_bindings depends on webcore_bindings_sources
and compiles these files.  Previously, the other webcore libs (webcore_svg,
webcore_html, webcore_remaining, etc) depended on webcore_bindings.  This changes the
dependency on webocre_bindings_sources so the build can parallelize the compile of
webcore_bindings and the other webcore_* libs.

No new tests, just changing the build dependencies.  Manually copy over the
include dirs that we used to get from webcore_bindings' direct_dependent_settings.

* WebCore.gyp/WebCore.gyp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94082 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Rename GraphicsContext3DInternal to GraphicsContext3DPrivate and add a dummy version of this class for Mac
https://bugs.webkit.org/show_bug.cgi?id=67172

Reviewed by Kenneth Russell.

Source/WebCore: 

* GNUmakefile.list.am:
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/chromium/Extensions3DChromium.h:
* platform/graphics/gtk/GraphicsContext3DGtk.cpp:
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::makeContextCurrent):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
* platform/graphics/gtk/GraphicsContext3DInternal.h: Removed.
* platform/graphics/gtk/GraphicsContext3DPrivate.h: Copied from Source/WebCore/platform/graphics/gtk/GraphicsContext3DInternal.h.
* platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3D::GraphicsContext3D):
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::getViewportGLWidget):
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):
(WebCore::GraphicsContext3DPrivate::boundingRect):
(WebCore::GraphicsContext3DPrivate::paint):
(WebCore::GraphicsContext3DPrivate::blitMultisampleFramebuffer):
(WebCore::GraphicsContext3DPrivate::blitMultisampleFramebufferAndRestoreContext):
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
(WebCore::GraphicsContext3D::platformLayer):
(WebCore::GraphicsContext3D::makeContextCurrent):
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::reshape):
(WebCore::GraphicsContext3D::activeTexture):
(WebCore::GraphicsContext3D::attachShader):
(WebCore::GraphicsContext3D::getAttachedShaders):
(WebCore::GraphicsContext3D::bindAttribLocation):
(WebCore::GraphicsContext3D::bindBuffer):
(WebCore::GraphicsContext3D::bindFramebuffer):
(WebCore::GraphicsContext3D::bindRenderbuffer):
(WebCore::GraphicsContext3D::bindTexture):
(WebCore::GraphicsContext3D::blendColor):
(WebCore::GraphicsContext3D::blendEquation):
(WebCore::GraphicsContext3D::blendEquationSeparate):
(WebCore::GraphicsContext3D::blendFunc):
(WebCore::GraphicsContext3D::blendFuncSeparate):
(WebCore::GraphicsContext3D::bufferData):
(WebCore::GraphicsContext3D::bufferSubData):
(WebCore::GraphicsContext3D::checkFramebufferStatus):
(WebCore::GraphicsContext3D::clearColor):
(WebCore::GraphicsContext3D::clear):
(WebCore::GraphicsContext3D::clearDepth):
(WebCore::GraphicsContext3D::clearStencil):
(WebCore::GraphicsContext3D::colorMask):
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::copyTexImage2D):
(WebCore::GraphicsContext3D::copyTexSubImage2D):
(WebCore::GraphicsContext3D::cullFace):
(WebCore::GraphicsContext3D::depthFunc):
(WebCore::GraphicsContext3D::depthMask):
(WebCore::GraphicsContext3D::depthRange):
(WebCore::GraphicsContext3D::detachShader):
(WebCore::GraphicsContext3D::disable):
(WebCore::GraphicsContext3D::disableVertexAttribArray):
(WebCore::GraphicsContext3D::drawArrays):
(WebCore::GraphicsContext3D::drawElements):
(WebCore::GraphicsContext3D::enable):
(WebCore::GraphicsContext3D::enableVertexAttribArray):
(WebCore::GraphicsContext3D::finish):
(WebCore::GraphicsContext3D::flush):
(WebCore::GraphicsContext3D::framebufferRenderbuffer):
(WebCore::GraphicsContext3D::framebufferTexture2D):
(WebCore::GraphicsContext3D::frontFace):
(WebCore::GraphicsContext3D::generateMipmap):
(WebCore::GraphicsContext3D::getActiveAttrib):
(WebCore::GraphicsContext3D::getActiveUniform):
(WebCore::GraphicsContext3D::getAttribLocation):
(WebCore::GraphicsContext3D::getError):
(WebCore::GraphicsContext3D::getString):
(WebCore::GraphicsContext3D::hint):
(WebCore::GraphicsContext3D::isBuffer):
(WebCore::GraphicsContext3D::isEnabled):
(WebCore::GraphicsContext3D::isFramebuffer):
(WebCore::GraphicsContext3D::isProgram):
(WebCore::GraphicsContext3D::isRenderbuffer):
(WebCore::GraphicsContext3D::isShader):
(WebCore::GraphicsContext3D::isTexture):
(WebCore::GraphicsContext3D::lineWidth):
(WebCore::GraphicsContext3D::linkProgram):
(WebCore::GraphicsContext3D::pixelStorei):
(WebCore::GraphicsContext3D::polygonOffset):
(WebCore::GraphicsContext3D::readPixels):
(WebCore::GraphicsContext3D::releaseShaderCompiler):
(WebCore::GraphicsContext3D::renderbufferStorage):
(WebCore::GraphicsContext3D::sampleCoverage):
(WebCore::GraphicsContext3D::scissor):
(WebCore::GraphicsContext3D::shaderSource):
(WebCore::GraphicsContext3D::stencilFunc):
(WebCore::GraphicsContext3D::stencilFuncSeparate):
(WebCore::GraphicsContext3D::stencilMask):
(WebCore::GraphicsContext3D::stencilMaskSeparate):
(WebCore::GraphicsContext3D::stencilOp):
(WebCore::GraphicsContext3D::stencilOpSeparate):
(WebCore::GraphicsContext3D::texParameterf):
(WebCore::GraphicsContext3D::texParameteri):
(WebCore::GraphicsContext3D::uniform1f):
(WebCore::GraphicsContext3D::uniform1fv):
(WebCore::GraphicsContext3D::uniform2f):
(WebCore::GraphicsContext3D::uniform2fv):
(WebCore::GraphicsContext3D::uniform3f):
(WebCore::GraphicsContext3D::uniform3fv):
(WebCore::GraphicsContext3D::uniform4f):
(WebCore::GraphicsContext3D::uniform4fv):
(WebCore::GraphicsContext3D::uniform1i):
(WebCore::GraphicsContext3D::uniform1iv):
(WebCore::GraphicsContext3D::uniform2i):
(WebCore::GraphicsContext3D::uniform2iv):
(WebCore::GraphicsContext3D::uniform3i):
(WebCore::GraphicsContext3D::uniform3iv):
(WebCore::GraphicsContext3D::uniform4i):
(WebCore::GraphicsContext3D::uniform4iv):
(WebCore::GraphicsContext3D::uniformMatrix2fv):
(WebCore::GraphicsContext3D::uniformMatrix3fv):
(WebCore::GraphicsContext3D::uniformMatrix4fv):
(WebCore::GraphicsContext3D::useProgram):
(WebCore::GraphicsContext3D::validateProgram):
(WebCore::GraphicsContext3D::vertexAttrib1f):
(WebCore::GraphicsContext3D::vertexAttrib1fv):
(WebCore::GraphicsContext3D::vertexAttrib2f):
(WebCore::GraphicsContext3D::vertexAttrib2fv):
(WebCore::GraphicsContext3D::vertexAttrib3f):
(WebCore::GraphicsContext3D::vertexAttrib3fv):
(WebCore::GraphicsContext3D::vertexAttrib4f):
(WebCore::GraphicsContext3D::vertexAttrib4fv):
(WebCore::GraphicsContext3D::vertexAttribPointer):
(WebCore::GraphicsContext3D::viewport):
(WebCore::GraphicsContext3D::getBooleanv):
(WebCore::GraphicsContext3D::getBufferParameteriv):
(WebCore::GraphicsContext3D::getFloatv):
(WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv):
(WebCore::GraphicsContext3D::getIntegerv):
(WebCore::GraphicsContext3D::getProgramiv):
(WebCore::GraphicsContext3D::getProgramInfoLog):
(WebCore::GraphicsContext3D::getRenderbufferParameteriv):
(WebCore::GraphicsContext3D::getShaderiv):
(WebCore::GraphicsContext3D::getShaderInfoLog):
(WebCore::GraphicsContext3D::getShaderSource):
(WebCore::GraphicsContext3D::getTexParameterfv):
(WebCore::GraphicsContext3D::getTexParameteriv):
(WebCore::GraphicsContext3D::getUniformfv):
(WebCore::GraphicsContext3D::getUniformiv):
(WebCore::GraphicsContext3D::getUniformLocation):
(WebCore::GraphicsContext3D::getVertexAttribfv):
(WebCore::GraphicsContext3D::getVertexAttribiv):
(WebCore::GraphicsContext3D::getVertexAttribOffset):
(WebCore::GraphicsContext3D::texImage2D):
(WebCore::GraphicsContext3D::texSubImage2D):
(WebCore::GraphicsContext3D::createBuffer):
(WebCore::GraphicsContext3D::createFramebuffer):
(WebCore::GraphicsContext3D::createProgram):
(WebCore::GraphicsContext3D::createRenderbuffer):
(WebCore::GraphicsContext3D::createShader):
(WebCore::GraphicsContext3D::createTexture):
(WebCore::GraphicsContext3D::deleteBuffer):
(WebCore::GraphicsContext3D::deleteFramebuffer):
(WebCore::GraphicsContext3D::deleteProgram):
(WebCore::GraphicsContext3D::deleteRenderbuffer):
(WebCore::GraphicsContext3D::deleteShader):
(WebCore::GraphicsContext3D::deleteTexture):

Source/WebKit/chromium: 

* WebKit.gyp:
* src/Extensions3DChromium.cpp:
(WebCore::Extensions3DChromium::Extensions3DChromium):
(WebCore::Extensions3DChromium::supports):
(WebCore::Extensions3DChromium::ensureEnabled):
(WebCore::Extensions3DChromium::isEnabled):
(WebCore::Extensions3DChromium::getGraphicsResetStatusARB):
(WebCore::Extensions3DChromium::blitFramebuffer):
(WebCore::Extensions3DChromium::renderbufferStorageMultisample):
(WebCore::Extensions3DChromium::mapBufferSubDataCHROMIUM):
(WebCore::Extensions3DChromium::unmapBufferSubDataCHROMIUM):
(WebCore::Extensions3DChromium::mapTexSubImage2DCHROMIUM):
(WebCore::Extensions3DChromium::unmapTexSubImage2DCHROMIUM):
(WebCore::Extensions3DChromium::setSwapBuffersCompleteCallbackCHROMIUM):
(WebCore::Extensions3DChromium::rateLimitOffscreenContextCHROMIUM):
(WebCore::Extensions3DChromium::paintFramebufferToCanvas):
* src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::initialize):
(WebCore::GraphicsContext3DPrivate::extractWebGraphicsContext3D):
(WebCore::GraphicsContext3DPrivate::platformGraphicsContext3D):
(WebCore::GraphicsContext3DPrivate::platformTexture):
(WebCore::GraphicsContext3DPrivate::grContext):
(WebCore::GraphicsContext3DPrivate::prepareTexture):
(WebCore::GraphicsContext3DPrivate::platformLayer):
(WebCore::GraphicsContext3DPrivate::markContextChanged):
(WebCore::GraphicsContext3DPrivate::markLayerComposited):
(WebCore::GraphicsContext3DPrivate::layerComposited):
(WebCore::GraphicsContext3DPrivate::paintFramebufferToCanvas):
(WebCore::GraphicsContext3DPrivate::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3DPrivate::paintCompositedResultsToCanvas):
(WebCore::GraphicsContext3DPrivate::paintRenderingResultsToImageData):
(WebCore::GraphicsContext3DPrivate::paintsIntoCanvasBuffer):
(WebCore::GraphicsContext3DPrivate::reshape):
(WebCore::GraphicsContext3DPrivate::getInternalFramebufferSize):
(WebCore::GraphicsContext3DPrivate::isContextLost):
(WebCore::GraphicsContext3DPrivate::isGLES2Compliant):
(WebCore::GraphicsContext3DPrivate::bindAttribLocation):
(WebCore::GraphicsContext3DPrivate::bufferData):
(WebCore::GraphicsContext3DPrivate::bufferSubData):
(WebCore::GraphicsContext3DPrivate::getActiveAttrib):
(WebCore::GraphicsContext3DPrivate::getActiveUniform):
(WebCore::GraphicsContext3DPrivate::getAttribLocation):
(WebCore::GraphicsContext3DPrivate::getContextAttributes):
(WebCore::GraphicsContext3DPrivate::getProgramInfoLog):
(WebCore::GraphicsContext3DPrivate::getShaderInfoLog):
(WebCore::GraphicsContext3DPrivate::getShaderSource):
(WebCore::GraphicsContext3DPrivate::getString):
(WebCore::GraphicsContext3DPrivate::getUniformLocation):
(WebCore::GraphicsContext3DPrivate::shaderSource):
(WebCore::GraphicsContext3DPrivate::texImage2D):
(WebCore::GraphicsContext3DPrivate::texSubImage2D):
(WebCore::GraphicsContext3DPrivate::uniform1fv):
(WebCore::GraphicsContext3DPrivate::uniform1iv):
(WebCore::GraphicsContext3DPrivate::uniform2fv):
(WebCore::GraphicsContext3DPrivate::uniform2iv):
(WebCore::GraphicsContext3DPrivate::uniform3fv):
(WebCore::GraphicsContext3DPrivate::uniform3iv):
(WebCore::GraphicsContext3DPrivate::uniform4fv):
(WebCore::GraphicsContext3DPrivate::uniform4iv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix2fv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix3fv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix4fv):
(WebCore::GraphicsContext3DPrivate::getExtensions):
(WebCore::GraphicsContext3DPrivate::isResourceSafe):
(WebCore::GraphicsContext3DPrivate::initializeExtensions):
(WebCore::GraphicsContext3DPrivate::supportsExtension):
(WebCore::GraphicsContext3DPrivate::ensureExtensionEnabled):
(WebCore::GraphicsContext3DPrivate::isExtensionEnabled):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
(WebCore::GraphicsContext3D::platformTexture):
(WebCore::GraphicsContext3D::grContext):
(WebCore::GraphicsContext3D::prepareTexture):
(WebCore::GraphicsContext3D::getInternalFramebufferSize):
(WebCore::GraphicsContext3D::isResourceSafe):
(WebCore::GraphicsContext3D::platformLayer):
(WebCore::GraphicsContext3D::layerComposited):
(WebCore::GraphicsContext3D::paintsIntoCanvasBuffer):
(WebCore::GraphicsContext3DPrivate::setContextLostCallback):
(WebCore::GraphicsContext3D::isGLES2Compliant):
(WebCore::GraphicsContext3DPrivate::setSwapBuffersCompleteCallbackCHROMIUM):
* src/GraphicsContext3DInternal.h: Removed.
* src/GraphicsContext3DPrivate.h: Copied from Source/WebKit/chromium/src/GraphicsContext3DInternal.h.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::graphicsContext3D):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94083 268f45cc-cd09-0410-ab3c-d52691b4dbfc
<rdar://problem/8832814> With large line-height, column break can happen anywhere in the
inter-line gap, causing staggered lines.
        
https://bugs.webkit.org/show_bug.cgi?id=67202 Handle positive leading when paginating lines.
        
Technically we should paginate lines based solely off their line top and line bottom with
leading included. However there are two issues with always doing so. The first is that overflow
can cause lines to overlap, and the second is that negative leading can cause lines to overlap.

Since we're incapable of dealing with overlap until we stop clipping column boxes and allow them
to have a form of specialized overflow, we still have to at least factor in overflow and ignore
negative leading for now. However we can at least honor positive leading when the lines don't
overlap. This patch provides basic support for paginating when positive leading is involved.

Reviewed by Dan Bernstein.

Added fast/multicol/positive-leading.html.

Source/WebCore: 

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::markLinesDirtyInBlockRange):
Renamed blockLogicalHeight() to lineBottomWithLeading(). The value is the same.

(WebCore::RenderBlock::adjustLinePositionForPagination):
Grow the top and extent of the line to include our leading when deciding how to paginate
the line.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeBlockDirectionPositionsForLine):
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::checkFloatsInCleanLine):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::determineEndPosition):
(WebCore::RenderBlock::matchedEndLine):
Renamed blockLogicalHeight() to lineBottomWithLeading(). The value is the same.

* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::adjustPosition):
(WebCore::RootInlineBox::alignBoxesInBlockDirection):
* rendering/RootInlineBox.h:
(WebCore::RootInlineBox::lineTopWithLeading):
(WebCore::RootInlineBox::lineBottomWithLeading):
(WebCore::RootInlineBox::setLineTopBottomPositions):
Instead of one member variable, blockLogicalHeight(), RootInlineBoxes now know both their top and
bottom including leading. These values are obtainable using lineTopWithLeading() and lineBottomWithLeading().
Add these two values to the setLineTopBottomPositions setter and remove setBlockLogicalHeight.

* rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::layoutRootBox):
Renamed blockLogicalHeight() to lineBottomWithLeading(). The value is the same.

LayoutTests: 

* fast/multicol/positive-leading.html: Added.
* platform/mac/fast/multicol/positive-leading-expected.png: Added.
* platform/mac/fast/multicol/positive-leading-expected.txt: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94084 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fix compile warning on clang:
error: 'WebKit::ChromeClientImpl::scrollRectIntoView' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
    virtual void scrollRectIntoView(
                     ^
../../WebCore/page/ChromeClient.h:171:22: note: hidden overloaded virtual function 'WebCore::ChromeClient::scrollRectIntoView' declared here
    virtual void scrollRectIntoView(const IntRect&) { }; // Currently only Mac has a non empty implementation.

* page/ChromeClient.h:
(WebCore::ChromeClient::scrollRectIntoView):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94085 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Roll chromium DEPS to r98771.

* DEPS:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94086 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt][WK2] Make mouse over work again for QDesktopWebView.
https://bugs.webkit.org/show_bug.cgi?id=67200

Reviewed by Noam Rosenthal.

The API has changed after QGraphicsView, SceneGraph sends
QHoverEvents now.

* UIProcess/qt/qdesktopwebpageproxy.cpp:
(QDesktopWebPageProxy::handleEvent):
(QDesktopWebPageProxy::handleHoverMoveEvent):
* UIProcess/qt/qdesktopwebpageproxy.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94087 268f45cc-cd09-0410-ab3c-d52691b4dbfc
REGRESSION (r93913): Failures in fast/replaced/frame-removed-during-resize.html and scrollbars/scrollable-iframe-remove-crash.html
https://bugs.webkit.org/show_bug.cgi?id=67074

Reviewed by Darin Adler.

Added flag m_isClosed to prevent events that cause Frame to be destroyed
from posting more events into EventQueue of a dying Document.

The tests mentioned above should now pass.

* dom/Document.cpp:
(WebCore::Document::detach):
* dom/EventQueue.cpp:
(WebCore::EventQueue::EventQueue):
(WebCore::EventQueue::enqueueEvent):
(WebCore::EventQueue::close): Renamed method to reflect better what it does.
* dom/EventQueue.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94088 268f45cc-cd09-0410-ab3c-d52691b4dbfc
querySelector/querySelectorAll should use selector checker fast path 
https://bugs.webkit.org/show_bug.cgi?id=67161

Reviewed by Sam Weinig.

Descendant and child selectors can be matches substantially faster using
SelectorChecker::fastCheckSelector() path. Currently it is used for style matching only.  
        
Add SelectorQuery class that can do both querySelector and querySelectorAll efficiently using
fast path. Use inlined loop for DOM traversal.
        
The patch is ~25% speedup in the overall native score of http://www.webkit.org/perf/slickspeed/.
Some individual subtests (using child or descendant selectors) execute twice as fast.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
(WebCore::CSSStyleSelector::SelectorChecker::isFastCheckableSelector):
(WebCore::RuleData::RuleData):
* css/CSSStyleSelector.h:
        
    Make fast path checking available outside CSSStyleSelector.
            
* dom/DOMAllInOne.cpp:
* dom/Node.cpp:
(WebCore::Node::querySelector):
(WebCore::Node::querySelectorAll):
        
    Switch to SelectorQuery.
        
* dom/SelectorNodeList.cpp: Removed.
* dom/SelectorNodeList.h: Removed.
        
    SelectorQuery makes these obsolete.

* dom/SelectorQuery.cpp: Added.
(WebCore::SelectorQuery::SelectorQuery):
(WebCore::SelectorQuery::queryAll):
(WebCore::SelectorQuery::queryFirst):
(WebCore::SelectorQuery::canUseIdLookup):
(WebCore::SelectorQuery::execute):
* dom/SelectorQuery.h: Added.
        
    Class for selector matching in tree.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94089 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed, rolling out r93924.
http://trac.webkit.org/changeset/93924
https://bugs.webkit.org/show_bug.cgi?id=67209

Bad baseline submitted for OS X. Should be chromium specific.
(Requested by dave_levin on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-30

* platform/mac/fast/text/complex-preferred-logical-widths-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94090 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fix chromium compile when using clang.  Another compile error due
to r94080.

* src/ChromeClientImpl.h:
(WebKit::ChromeClientImpl::scrollRectIntoView):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94091 268f45cc-cd09-0410-ab3c-d52691b4dbfc
<rdar://problem/10002140> 9A309: Text gets clipped in book because of overflow:auto
        
https://bugs.webkit.org/show_bug.cgi?id=67212 - Text gets clipped in multi-column layouts when overflow:auto
is used.
        
Revise our overflow:auto pagination behavior. If the overflow block doesn't specify any logical height
information, then we'll just assume the plan is for it to enclose its contents, and we will be willing
to paginate in those circumstances.

Reviewed by Dan Bernstein.

Added overflow-across-columns.html and overflow-unsplittable.html

Source/WebCore: 

* rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustForUnsplittableChild):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::hasUnsplittableScrollingOverflow):
* rendering/RenderBox.h:

LayoutTests: 

* fast/multicol/overflow-across-columns.html: Added.
* fast/multicol/overflow-unsplittable.html: Added.
* platform/mac/fast/multicol/overflow-across-columns-expected.png: Added.
* platform/mac/fast/multicol/overflow-across-columns-expected.txt: Added.
* platform/mac/fast/multicol/overflow-unsplittable-expected.png: Added.
* platform/mac/fast/multicol/overflow-unsplittable-expected.txt: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94092 268f45cc-cd09-0410-ab3c-d52691b4dbfc
        DumpRenderTree should begin each test with an empty cookie store
        https://bugs.webkit.org/show_bug.cgi?id=63545
        <rdar://problem/5666907>

        Reviewed by Darin Adler.

        Use a clean CFURLStorageSession when this functionality is available.

        * WebCore.exp.in: Added exports.

        * WebCore.xcodeproj/project.pbxproj: Made CookieStorageCFNet.h private, as currentCFHTTPCookieStorage
        is used in WebKit.

        * platform/mac/CookieJar.mm:
        (WebCore::cookies):
        (WebCore::cookieRequestHeaderFieldValue):
        (WebCore::setCookies):
        (WebCore::cookiesEnabled):
        (WebCore::getRawCookies):
        (WebCore::deleteCookie):
        Updated to use currentCFHTTPCookieStorage().

        * platform/network/CookieStorage.h: Moved CFNetwork specific declarations to CookieStorageCFNet.h.

        * platform/network/ResourceHandle.cpp: Moved CFNetwork specific code to ResourceHandleCFNet.cpp.

        * platform/network/ResourceHandle.h: Exposed default session support on Mac, too. Made
        privateBrowsingStorageSession() private, as callers shouldn't be concerned about where the
        current sssion came from.

        * platform/network/cf/CookieJarCFNet.cpp:
        (WebCore::setCookies):
        (WebCore::cookies):
        (WebCore::cookieRequestHeaderFieldValue):
        (WebCore::cookiesEnabled):
        (WebCore::getRawCookies):
        (WebCore::deleteCookie):
        (WebCore::getHostnamesWithCookies):
        (WebCore::deleteCookiesForHostname):
        (WebCore::deleteAllCookies):
        Updated to use currentCFHTTPCookieStorage().

        * platform/network/cf/CookieStorageCFNet.cpp:
        (WebCore::cookieStorageOverride): Make it clear that this override is only for a Windows API.
        (WebCore::overrideCookieStorage): Ditto.
        (WebCore::currentCFHTTPCookieStorage): We no longer store a cookie storage in a static variable,
        unless it has been overridden on Windows. We can always get it from a session.
        (WebCore::setCookieStoragePrivateBrowsingEnabled): There is nothing to do here - we'll just
        use private session's storage. Note that Mac has a separate code path for OS versions that
        don't support sessions.
        (WebCore::startObservingCookieChanges): Updated to use currentCFHTTPCookieStorage().
        (WebCore::stopObservingCookieChanges): Ditto.

        * platform/network/cf/CookieStorageCFNet.h: Changed exposed methods for more clarity.

        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::makeFinalRequest): Updated for currentCookieStorage->currentCFHTTPCookieStorage change.
        (WebCore::ResourceHandle::createPrivateBrowsingStorageSession): Moved out of USE(CFNETWORK),
        as this function is also used with NSURLConnection when sessions are enabled.
        (WebCore::ResourceHandle::currentStorageSession): Ditto. Removed an #if since default session
        is now supported on Mac, too.
        (WebCore::defaultCFURLStorageSession): Moved out of USE(CFNETWORK).
        (WebCore::ResourceHandle::setDefaultStorageSession): Moved out of USE(CFNETWORK). No longer
        adopt the session, because nothing in method name says that it will steal a reference from
        the caller.
        (WebCore::ResourceHandle::defaultStorageSession): Moved out of USE(CFNETWORK).
        (WebCore::privateStorageSession): Moved from ResourceHandle.cpp.
        (WebCore::privateBrowsingStorageSessionIdentifierBase): Moved from ResourceHandle.cpp.
        (WebCore::ResourceHandle::setPrivateBrowsingEnabled): Moved from ResourceHandle.cpp.
        (WebCore::ResourceHandle::privateBrowsingStorageSession): Moved from ResourceHandle.cpp.
        (WebCore::ResourceHandle::setPrivateBrowsingStorageSessionIdentifierBase): Moved from ResourceHandle.cpp.
        (WebCore::ResourceHandle::privateBrowsingStorageSessionIdentifierDefaultBase): Moved from ResourceHandle.cpp.

        * platform/network/mac/CookieStorageMac.mm: (WebCore::setCookieStoragePrivateBrowsingEnabled):
        We no longer store a reference to cookie storage in a static variable, so nothing to do here.
        On older OS versiosn, we still need to enable legacy private browsing mode.

        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::shouldRelaxThirdPartyCookiePolicy): Updated to use the new currentCFHTTPCookieStorage function.
        (WebCore::ResourceHandle::createNSURLConnection): Updated to use currentStorageSession()
        instead of privateBrowsingStorageSession().
        (WebCore::ResourceHandle::willSendRequest): Ditto.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94093 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[chromium] Update baselines after r94084 and r94088 and r93909.

* platform/chromium-cg-mac/fast/multicol/positive-leading-expected.png: Added.
* platform/chromium-cg-mac/fast/text/complex-preferred-logical-widths-expected.txt: Removed.
* platform/chromium-linux/fast/multicol/positive-leading-expected.png: Added.
* platform/chromium-linux/fast/multicol/single-line-expected.png:
* platform/chromium-linux/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
* platform/chromium-linux/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
* platform/chromium-linux/fast/repaint/multicol-repaint-expected.txt: Removed.
* platform/chromium-win/fast/multicol/positive-leading-expected.png: Added.
* platform/chromium-win/fast/multicol/positive-leading-expected.txt: Added.
* platform/chromium-win/fast/multicol/single-line-expected.png:
* platform/chromium-win/fast/multicol/single-line-expected.txt:
* platform/chromium-win/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
* platform/chromium-win/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
* platform/chromium-win/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
* platform/chromium-win/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
* platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
* platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
* platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
* platform/chromium-win/fast/multicol/table-vertical-align-expected.txt:
* platform/chromium-win/fast/repaint/multicol-repaint-expected.png:
* platform/chromium-win/fast/repaint/multicol-repaint-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94094 268f45cc-cd09-0410-ab3c-d52691b4dbfc
TypedArrays don't ensure that denormalised values are normalised
https://bugs.webkit.org/show_bug.cgi?id=67178

Reviewed by Gavin Barraclough.

../../../../Volumes/Data/git/WebKit/OpenSource/LayoutTests:

Add test to ensure that we create a non-signalling nan when reading
a singaling nan from a typed array.

* fast/canvas/webgl/webgl-array-invalid-ranges-expected.txt:
* fast/canvas/webgl/webgl-array-invalid-ranges.html:

../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:

Add a couple of assertions to jsNumber() to ensure that
we block signaling NaNs

* runtime/JSValue.h:
(JSC::jsDoubleNumber):
(JSC::jsNumber):

../../../../Volumes/Data/git/WebKit/OpenSource/Source/WebCore:

Ensure that we convert singaling nans to silent nans when loading
from a typed array.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94095 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-08-29  Darin Fisher  <darin@chromium.org>

        [chromium] DumpRenderTree should be explicit about its dependency on
        GoogleURL
        https://bugs.webkit.org/show_bug.cgi?id=67169

        Reviewed by Ryosuke Niwa.

        DumpRenderTree uses GoogleURL code directly, and it should be explicit
        about that instead of picking up this dependency transitively, which
        only works for the static build.

        This is needed to support the "component" build of DumpRenderTree, in
        which the various Chromium dependencies are built as separate DLLs.

        * WebKit.gyp:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94096 268f45cc-cd09-0410-ab3c-d52691b4dbfc
        fast/loader/document-destruction-within-unload.html causes an assertion failure in the next
        test (currently, document-with-fragment-url-1.html)
        https://bugs.webkit.org/show_bug.cgi?id=66783

        * platform/mac/Skipped: Skipping the offending test.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94099 268f45cc-cd09-0410-ab3c-d52691b4dbfc