Excellent feedback.


On Tue, Apr 23, 2013 at 5:45 PM, Michael Grosser
<notifications@github.com>wrote:

> In spec/soft_deletion_spec.rb:
>
> > @@ -207,6 +207,35 @@ def self.successfully_bulk_soft_deletes
> >          end
> >        end
> >
> > +      if ActiveRecord::VERSION::MAJOR == 3
>
> More descriptive names would be nice like .with_deleted it should find
> deleted and undeleted / .only_delete it should find deleted and no
> undeleted
>
> A test for a combination of scopes would be nice, to make sure it does not
> blow up like Category.where("xyz").with_delete)orCategory.with_delete
> ).where("xyz")
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/grosser/soft_deletion/pull/10/files#r3929195>
> .
>