Putting all the requirements into one interface means anyone using knows
everything they need to do from a single location. That'll make things
easier. I agree with Rouven.

-ds

On Jun 3, 2013, at 14:56, "Rouven Weßling" <notifications@github.com> wrote:

In src/Joomla/Input/InputInterface.php:

> +<?php
> +/**
> + * Part of the Joomla Framework Input Package
> + *
> + * @copyright  Copyright (C) 2005 - 2013 Open Source Matters, Inc. All rights reserved.
> + * @license    GNU General Public License version 2 or later; see LICENSE
> + */
> +
> +namespace Joomla\Input;
> +
> +/**
> + * Input class interface
> + *
> + * @since  1.0
> + */
> +interface InputInterface

At least Countable definitely. Otherwise you can't be sure that you can do
count($input) in a method type hinted with this interface. Serializable is
a bit of a different case since you can still (un-)serialize it if the
interface is not present so it might actually be good to keep it outside.

—
Reply to this email directly or view it on
GitHub<https://github.com/joomla/joomla-framework/pull/173/files#r4508252>
.