I think you could update the docstring, other than that it looks good.