Mark, this is what I did in other repositories (btw, ModuleHandler should
be renamed to ModuleRepository I guess).

It means that we don't know how to sort on arbitrary criteria, and this is
to protect against users believing that they can pass any Pageable


On Mon, Sep 30, 2013 at 8:50 PM, Mark Fisher <notifications@github.com>wrote:

> In
> spring-xd-dirt/src/main/java/org/springframework/xd/dirt/module/ModuleHandler.java:
>
> > +
> > +/**
> > + *
> > + * @author Glenn Renfro
> > + */
> > +public class ModuleHandler {
> > +
> > +	ModuleRegistry moduleRegistry;
> > +
> > +	public ModuleHandler(ModuleRegistry moduleRegistry) {
> > +		this.moduleRegistry = moduleRegistry;
> > +	}
> > +
> > +	public Page<ModuleDefinition> findAll(Pageable pageable) {
> > +		List<ModuleDefinition> definitions = moduleRegistry.findDefinitions();
> > +		Assert.isNull(pageable.getSort(), "Arbitrary sorting is not implemented");
>
> what does this mean? "Arbitrary sorting is not implemented"
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/spring-projects/spring-xd/pull/315/files#r6666955>
> .
>