@Override is optional in Java, I certainly don't use it religiously myself.
If this doesn't compile it may be removed in a later commit, although I
could swear I checked each pull request was clean, maybe there are some
partial commits that are flawed.


On Sat, Apr 13, 2013 at 4:15 PM, Dan Frank <notifications@github.com> wrote:

> In src/main/java/ly/bit/nsq/lookupd/BasicLookupdJob.java:
>
> > -		List<String> producers = lookupd.query(reader.getTopic());
> > -		for(String producer : producers) {
> > -			String[] components = producer.split(":");
> > -			String nsqdAddress = components[0];
> > -			int nsqdPort = Integer.parseInt(components[1]);
> > -			try {
> > -				reader.connectToNsqd(nsqdAddress, nsqdPort);
> > -			} catch (NSQException e) {
> > -				// TODO Auto-generated catch block
> > -				e.printStackTrace();
> > -			}
> > -		}
> > -	}
> > -	
> > -}
> > +    @Override()
>
> This is actually failing to compile for me with the Override decorator -
> I'm getting the message that this should be used for overriding superclass
> methods, but not implementing interface methods. Think we need to remove it
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/bitly/nsq-java/pull/3/files#r3784498>
> .
>