updated with supply query params