Dear Sir,
Do you mean you want me to send a new pull request after taking into consideration your notes or you mean you want me to take these notes into consideration next time I sent a pull request ?
Awaiting your kind reply.
Thanks for your kind interest,AMS
Date: Sat, 26 Oct 2013 14:56:04 -0700
From: notifications@github.com
To: joomla-cms@noreply.github.com
CC: abdms.itech@hotmail.com
Subject: Re: [joomla-cms] fix parsing schemas with mysqli driver type (#2305)

In libraries/cms/installer/installer.php:

> @@ -1064,8 +1064,16 @@ public function parseSchemaUpdates(SimpleXMLElement $schema, $eid)
>  				foreach ($schemapaths as $entry)
>  				{
>  					$attrs = $entry->attributes();
> +					
> +					//assuming that the type is a mandatory attribute but if it is not mandatory then there should be a discussion for it.

Please leave a space between the // and the start of your comment. Also please start the comment with a capital letter :) thanks!


—
Reply to this email directly or view it on GitHub.