Yes, Obsolete it in v5 and change it like you suggest


On Tue, May 14, 2013 at 6:58 AM, danielmarbach <notifications@github.com>wrote:

> In src/NServiceBus.Core/TransportMessage.cs:
>
> > @@ -54,21 +47,6 @@ public string Id
> >          public void ChangeMessageId(string newId)
> >          {
> >              id = newId;
> > -            Headers[NServiceBus.Headers.IdForCorrelation] = newId;
> > -        }
> > -
> > -        /// <summary>
> > -        /// Gets/sets the identifier that is copied to <see cref="CorrelationId"/>.
> > -        /// </summary>
> > -        public string IdForCorrelation
>
> What about making sure that IdForCorellation always reflects the
> CorrelationId and vice versa and also when set sets the header? Because I
> wrote also an ingoing and outgoing mutator that would work. Thoughts? Am
> 14.05.2013 um 06:41 schrieb Simon Cropp <notifications@github.com>:
> … <#13ea1675d46007ef_>
>  In src/NServiceBus.Core/TransportMessage.cs: > @@ -54,21 +47,6 @@ public
> string Id > public void ChangeMessageId(string newId) > { > id = newId; > -
> Headers[NServiceBus.Headers.IdForCorrelation] = newId; > - } > - > - ///
> <summary> > - /// Gets/sets the identifier that is copied to <see
> cref="CorrelationId"/>. > - /// </summary> > - public string
> IdForCorrelation FYI example usages of IdForCorrelation in the wild
> http://stackoverflow.com/questions/12816437/on-premise-nservicebus-applicaton-receiving-messages-from-azure-servicebus-queue
> http://www.teinum.no/2012/03/nservicebus-30-smtp-transport.html
> https://github.com/valeriob/MessageMonitor/blob/master/MessageMonitor.Service/Mapping_Extensions.csso is there going to be an alternative approach that applies to these
> usages? — Reply to this email directly or view it on GitHub.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/NServiceBus/NServiceBus/pull/1173/files#r4207823>
> .
>



-- 
http://andreasohlund.net
http://twitter.com/andreasohlund