On Fri, Feb 15, 2013 at 4:04 PM, Daniel James <notifications@github.com>wrote:

> In src/main/scala/DatomicData.scala:
>
> > @@ -139,8 +165,14 @@ object DId {
> >    def apply(partition: Partition) = new TempId(partition, None, DId.tempid(partition))
> >    def apply(id: Long) = new FinalId(id)
> >    def apply(id: DLong) = new FinalId(id.underlying)
> > +
> > +  def unapply(ref: DRef): Option[DId] = ref.underlying match {
>
> so one could write
>
> DRef(DId(Partition.USER)) match {
>   case DId(id) => …}
>
> which would be the same as
>
> DRef(DId(Partition.USER)) match {
>   case DRef.IsId(id) => …}
>
> ?
>

I thought about it but the problem is for Keyword...
Keyword is Term, not a DatomicData...
DId is a DatomicData.
Introducing a dep in DId with respect to DRef can be accepted but for
Keyword, I don't really think this is good!


>  —
> Reply to this email directly or view it on GitHub<https://github.com/pellucidanalytics/datomisca/pull/10/files#r3029727>.
>
>