In this element there is an inline style placing this object in the middle
(probably gwt related, I don't know the source of it). I did that vs using
an !important css declaration which will cause IE8 problems. What you think
is the best solution?


On 26 June 2013 19:00, Rob Fellows <notifications@github.com> wrote:

> In
> user-console/source/org/pentaho/mantle/client/dialogs/scheduling/ScheduleOutputLocationDialog.java:
>
> > @@ -128,6 +129,7 @@ public void onKeyUp(KeyUpEvent event) {
> >
> >      setContent(content);
> >      content.getElement().getStyle().clearHeight();
> > +    content.getElement().getParentElement().getStyle().setVerticalAlign(VerticalAlign.TOP);
>
> I would prefer to see this done via CSS. the way you have done it will
> inline the style on the DOM element and therefore not be override-able with
> css. It might also make sense to
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/pentaho/pentaho-platform/pull/659/files#r4897656>
> .
>



-- 
Diogo Mariano
Development Team

http://www.webdetails.pt