Currently in the spec, the BaseBuilder is runnable. If it is empty it will
break the test. I am actually in favor of not directly using BaseBuilder,
by setting these 2 methods raise 'not implemented'. that enforce other to
use subclass.


On Wed, Feb 6, 2013 at 11:09 AM, Ankur Chauhan <notifications@github.com>wrote:

> In lib/stemcell/builder.rb:
>
> >        stemcell_mf_path = File.expand_path "stemcell.MF", @prefix
> >        File.open(stemcell_mf_path, "w") do |f|
> >          f.write(@manifest.to_yaml)
> >        end
> > -
> > -      files.push image_path, stemcell_mf_path
> > -      package_files(files)
> > +    end
> > +
> > +    def generate_image
> > +      FileUtils.touch File.join(@prefix, "image")
> > +    end
> > +
> > +    def generate_pkg_list
> > +      FileUtils.touch File.join(@prefix, "stemcell_dpkg_l.txt")
>
> Why do this? why not just leave it empty?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/ankurcha/stemcell/pull/2/files#r2904641>.
>
>



-- 
Best Regards,
Yongkun