Please don't remote it from the parent pom. Not all JBoss projects require
JDK 7, and afaik even some versions of JDK7 on mac required this.


On Tue, Nov 5, 2013 at 2:37 PM, Tomaz Cerar <notifications@github.com>wrote:

> In testsuite/pom.xml:
>
> >                  <scope>import</scope>
> >                  <type>pom</type>
> >              </dependency>
> > +            <dependency>
> > +                <groupId>com.sun</groupId>
> > +                <artifactId>tools</artifactId>
> > +                <version>1.7</version>
> > +                <scope>system</scope>
> > +                <systemPath>${java.home}/../lib/tools.jar</systemPath> <!-- since jdk7 also on MAC this is proper path -->
>
> Yes it works on all platforms. Tested on few mac boxes.
> I personally don't want it in parent pom as we only use it in testsuite
> anyways. I also sent PR to jboss parent to remove it there as well. see
> jboss/jboss-parent-pom@d890cd7<https://github.com/jboss/jboss-parent-pom/commit/d890cd75fb1c889fbdda49c20d8477fdb084b2c1>
> As there is no more need for special profiles mac vs everyone else anymore.
> Most projects are fine without tools dependency and if they need it, it is
> easy to add it. Even we need it only for testsuite.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/wildfly/wildfly/pull/5404/files#r7430107>
> .
>