change all to all_data