Add rudimentary error checks and reformat comments

There were a number of functions assigning their return value to
`error` without much explanation.  I added in some rudimentary
error checking to help flesh out the example.

Also, I reformatted all of the comments down to 80 cols (and in
some cases, slightly updated the wording).
Fix memory leak in p_getaddrinfo on Amiga

If gethostbyname() fails on platforms with NO_ADDRINFO, the code
leaks the struct addrinfo that was allocated.  This fixes that
(and a number of code formatting issues in that area of code in
src/posix.c).
Clear up warnings from cppcheck

The cppcheck static analyzer generates warnings for a bunch of
places in the libgit2 code base.  All the ones fixed in this
commit are actually false positives, but I've reorganized the
code to hopefully make it easier for static analysis tools to
correctly understand the structure.  I wouldn't do this if I
felt like it was making the code harder to read or worse for
humans, but in this case, these fixes don't seem too bad and will
hopefully make it easier for better analysis tools to get at any
real issues.
Merge pull request #1344 from arrbee/fix-static-analyzer-issues

Fix static analyzer issues
Simplify signature parsing
signature: Shut up MSVC, you silly goose
signature: Small cleanup
Disable caching in Clar
Merge pull request #1349 from libgit2/clar-no-cache

Disable caching in Clar
Merge pull request #1348 from libgit2/signatures-2

Simplify signature parsing
Store treebuilder length separately from entries vec

The treebuilder entries vector flags removed items which means
we can't rely on the entries vector length to accurately get the
number of entries.  This adds an entrycount value and maintains it
while updating the treebuilder entries.
Some code cleanups in tree.c

This replaces most of the explicit vector iteration with calls
to git_vector_foreach, adds in some git__free and giterr_clear
calls to clean up during some error paths, and a couple of
other code simplifications.
Merge pull request #1350 from arrbee/fix-1292

Add explicit entrycount to tree builder
Add more treebuilder tests

The recent changes with git_treebuilder_entrycount point out that
the test coverage for git_treebuilder_remove and
git_treebuilder_entrycount is completely absent.  This adds tests.
Merge pull request #1351 from arrbee/moar-treebuilder-tests

Add more treebuilder tests
add a sorter to the reuc on index creation
Merge pull request #1352 from ethomson/reuc_sort

add a sorter to the reuc on index creation
ignore: enhance git_ignore_path_is_ignored() test coverage
stash: Refactor stash::drop tests
stash: Update the reference when dropping the topmost stash