Hey Prashant,

I meant that we not longer need to pass the URI here because when we past
the list of Jars we just list each jar with a full URI. So I think this can
just be removed.


On Wed, Dec 18, 2013 at 4:55 AM, Prashant Sharma
<notifications@github.com>wrote:

> In core/src/main/scala/org/apache/spark/SparkEnv.scala:
>
> >
> > -    val (actorSystem, boundPort) = AkkaUtils.createActorSystem("spark", hostname, port)
> > -
> > -    // Bit of a hack: If this is the driver and our port was 0 (meaning bind to any free port),
> > -    // figure out which port number Akka actually bound to and set spark.driver.port to it.
> > -    if (isDriver && port == 0) {
> > -      System.setProperty("spark.driver.port", boundPort.toString)
> > +    val httpFileServer = new HttpFileServer()
> > +    httpFileServer.initialize()
> > +    val conf = ConfigFactory.
> > +      parseString( s"""spark.fileserver.uri = "${httpFileServer.serverUri}" """)
>
> Hey Patrick, What did you mean by "It looks like now we instead just
> encode the URI in the reference to the jar itself." Did you mean that
> instantiating this server is not required anymore in SparkEnv at all ?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/apache/incubator-spark/pull/230/files#r8434817>
> .
>