Arh actually I read the code again, I previously have the salt_column also in the all_columns array, that's why I need that check. Since it's not on there anymore, I do not need to worry about that anymore. Removed.


On 4/16/13 4:26 PM, "James Taylor" <notifications@github.com> wrote:

In src/main/java/com/salesforce/phoenix/schema/PTableImpl.java:
>          RowKeySchemaBuilder builder = new RowKeySchemaBuilder();
> -        for (int i = 0; i < allColumns.length; i++) {
> +        this.columnsByName = ArrayListMultimap.create(columns.size(), 1);
> +        allColumns = new PColumn[columns.size()];
> +        if (bucketNum != null && !columns.get(0).getName().getString().equals(SALTING_COLUMN.getName().getString())) {
I don't think you should need this AND clause:  && !columns.get(0).getName().getString().equals(SALTING_COLUMN.getName().getString())

-
Reply to this email directly or view it on GitHub <https://github.com/forcedotcom/phoenix/pull/139/files#r3823525> .