Clean up started volume services in tests.

The test_preattach_status_volume test was failing due to state left by
another test. The interim solution was to skip the aforementioned test.
I tracked down the problem to 4 tests in test_admin_actions.py that
call self.start_service('volume', host='test'), and don't stop the
service. Stopping it in all 4 tests solves the problem.

HOWEVER, I don't know why these started services caused this particular
test to fail. I am still working to figure that out, but maybe someone
has an idea.

Change-Id: I2a5caaae9f61e7c7617c934917a10cf1cf3c0db6
Fixes: bug 1153108
Mark sql_connection with secret flag

sql_connection contains the password in some setups and marking as
secret prevents accidental logging

fixes bug 1160680

Change-Id: I3704237d0923bb30138b5ece7e5c7bbda0a78b9b
getLogger should be called after logging is configured

logging needs to be setup properly before we try to log
something. Fixed one spot from logging->LOG

Fixes LP# 1161038

Change-Id: I87743cff9062e47c1d5e989c2c0c05c3921b65c7
Add snapshot events to the cinder notification

Added and tested snapshot.create.start & snapshot.create.end
on creation of a new snapshot

Added and tested snapshot.delete.start & snapshot.delete.end
on the deletion of a snapshot

Change-Id: Ic3c1cc8949109149c59cf106a24b4eb0d8ba5580
Enforce exclusive options snapshot-id, source-volid and image-id

Fixed checks in api that volume create receives only one of
snapshot-id, source-volid or image-id.

Fixes bug #1161437

Change-Id: Ibe5ca4bb81e69b0f8e1abe1c2cffe587dc10e3ca
Merge "Mark sql_connection with secret flag"
Merge "getLogger should be called after logging is configured"
REST session validity not checked in get_volume_info

The fix for bug 1157242 introduced a new bug in Coraid cinder driver
_get_volume_info that the login session is not checked for
validity/timeout.  This change addressesthat issue for all
methods in the CoraidRESTClient class.

Fixes bug 1160459

Change-Id: Ib2d7ebbf3ef8ec35071f51c6168eb9b3af9405e6
Merge "Add snapshot events to the cinder notification"
Merge "REST session validity not checked in get_volume_info"
Fix IBM copyright strings

Update IBM copyright strings to one consistant format

Change-Id: I848f2bf64376b4e9496d8f54ae52321a6c4a4314
remove deprecated assert_unicode sqlalchemy attribute

Removing this enables use with sqlalchemy 0.8.0
The deprecation is described upstream at:
http://docs.sqlalchemy.org/en/latest/changelog/changelog_08.html#change-ad44af79c886d1bb283042deb64f9cbe

Change-Id: I305bfdbcd3c3669c41318ea34115624f729b3909
Throw InvalidSnapshot for failed snap delete

When delete is called for a snapshot not in the "available" or
"error" state, throw an InvalidSnapshot exception rather than
InvalidVolume.

Change-Id: I47f55b3357d75b5c0c9a704aaf693f4764fd112c
Add availability_zone to the volume and snapshot notifications

Change-Id: I27b6dde68a1618a02c2309f007ead9dd1f04879e
Remove InvalidPortRange exception

The InvalidPortRange exception seems to be left over from the
initial split from Nova.

Change-Id: Ife03ac70f6ba80273c1c21e8d2c509b480a6fe80
Merge "Remove InvalidPortRange exception"
Merge "Add availability_zone to the volume and snapshot notifications"
Merge "remove deprecated assert_unicode sqlalchemy attribute"
Change format of some judgments

Because "not volume" will be True if volume id is 0.It can not
distinguish 0 from None.The same to some other judgments where
variable value may be 0.

This patch also does the following changes:
Deletes check storagepool in function _check_conf_file and adds
check default iscsi target IP in function initialize_connection.
Moves create host group from do_setup to initialize_connection.
Changes _get_login_info to be _update_login_info.

Fixes bug: 1160340
Change-Id: I0434b587d57c783f10d5724c4c66aea5df0b32e5
Merge "Fix IBM copyright strings"