change param names for export
modify docs