On Fri, Nov 22, 2013 at 10:21 AM, Josh Moore <notifications@github.com>wrote:

> In components/bio-formats/src/loci/formats/in/CellVoyagerReader.java:
>
> > +		OMEXMLMetadata omeMD = null;
> > +
> > +		if ( service != null )
> > +		{
> > +			try
> > +			{
> > +				omeMD = service.createOMEXMLMetadata( xml );
> > +			}
> > +			catch ( final ServiceException e )
> > +			{
> > +				LOGGER.debug( "", e );
> > +			}
> > +		}
> > +
> > +		// Correct pixel size for magnification
> > +		omeMD.setPixelsPhysicalSizeX( new PositiveFloat( omeMD.getPixelsPhysicalSizeX( 0 ).getValue().doubleValue() / magnification ), 0 );
>
> findbugs is complaining (correctly) that omeMD could be null here if
> service is null:
>
> http://hudson.openmicroscopy.org.uk/view/Failing/job/BIOFORMATS-merge-develop/616/findbugsResult/new/HIGH/
> Likely this whole block (481-514) could be simplified down to a single try
> block which throws if omeMD is left null.
>
>

Hi Josh,
pushed, can you check that what I did is ok?
Best
jy