@mzdaniel can you make sure this group doesn't conflict with that other
software package called "docker"? This would create confusion and a
possible security risk for a sysadmin who installs both. (although that is
unlikely, since the other docker is a desktop gadget).


On Fri, Aug 9, 2013 at 6:13 PM, Michael Crosby <notifications@github.com>wrote:

> In api.go:
>
> > @@ -1087,7 +1088,20 @@ func ListenAndServe(proto, addr string, srv *Server, logging bool) error {
> >  		return e
> >  	}
> >  	if proto == "unix" {
> > -		os.Chmod(addr, 0700)
> > +		os.Chmod(addr, 0660)
> > +		groups, err := ioutil.ReadFile(`/etc/group`)
> > +		if err != nil {
> > +			return err
> > +		}
> > +		re := regexp.MustCompile("docker:.*?
> :([0-9]+)")
> > +		if gid := re.FindStringSubmatch(string(groups)); gid != nil {
> > +			gid, err := strconv.Atoi(gid[1])
>
> You are using the same variable name for two different types. This can be
> a little confusing, do you think that we could change the first one to
> something else?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/dotcloud/docker/pull/1485/files#r5696502>
> .
>