That is reasonable.


On Tue, Dec 10, 2013 at 4:46 PM, Keith Kyzivat <notifications@github.com>wrote:

> In src/civetweb.c:
>
> >  #if defined(USE_IPV6)
> > +        snprintf(buf, len, "%x:%x:%x:%x:%x:%x:%x:%x",
> > +                 usa->sin6.sin6_addr.u.Word[0], usa->sin6.sin6_addr.u.Word[1], usa->sin6.sin6_addr.u.Word[2], usa->sin6.sin6_addr.u.Word[3],
> > +                 usa->sin6.sin6_addr.u.Word[4], usa->sin6.sin6_addr.u.Word[5], usa->sin6.sin6_addr.u.Word[6], usa->sin6.sin6_addr.u.Word[7]);
> > +#endif
> > +    }
> > +#else
> >      inet_ntop(usa->sa.sa_family, usa->sa.sa_family == AF_INET ?
> >                (void *) &usa->sin.sin_addr :
> >                (void *) &usa->sin6.sin6_addr, buf, len);
>
> Cannot refer to usa->sin6.sin6_addr if !defined(USE_IPV6).
> Also, I think determining whether to fill in buf with sin_addr vs
> sin6_addr could be done for all platforms, with the sin6_addr code being
> protected by #if defined(USE_IPV6).
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/sunsetbrew/civetweb/pull/37/files#r8248881>
> .
>