Yes, I think this would be good


2013/4/19 Soumyajit De <notifications@github.com>

> In src/shogun/mathematics/Statistics.cpp:
>
> > +	REQUIRE(cov.sparse_matrix,
> > +		"CStatistics::sample_from_gaussian(): \
> > +		Covariance is not initialized!\n");
> > +	REQUIRE(cov.num_vectors==cov.num_features,
> > +		"CStatistics::sample_from_gaussian(): \
> > +		Covariance should be square matrix!\n");
> > +	REQUIRE(mean.vlen==cov.num_vectors,
> > +		"CStatistics::sample_from_gaussian(): \
> > +		Mean and covariance dimension mismatch!\n");
> > +
> > +	int32_t dim=mean.vlen;
> > +	Map<VectorXd> mu(mean.vector, mean.vlen);
> > +	const SparseMatrix<float64_t> &c=EigenSparseUtil<float64_t>::toEigenSparse(cov);
> > +	typedef SparseMatrix<float64_t> MatrixType;
> > +
> > +#ifdef EIGEN_YES_I_KNOW_SPARSE_MODULE_IS_NOT_STABLE_YET
>
> @karlnapf <https://github.com/karlnapf> I didn't add the extended
> SimplicialCholesky in the eigen3.h yet. We only need to handle it this way
> when we need to access the upper and lower factors. Shall I add this to
> eigen3.h too?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/shogun-toolbox/shogun/pull/989/files#r3876933>
> .
>