the pool should be unaware of the counting (you're right) but not the
connection creation, i think...
the connection's associated stuff should be part of the pool and the
stack's ones should be part of timedstack.

what do you think?

regards



2013/9/3 Bruno Coelho <brunoflcoelho@gmail.com>

> hi, you'r eright, i'll look into it asap.
>
> tks
>
>
> 2013/9/2 Mike Perham <notifications@github.com>
>
>> In lib/connection_pool/timed_stack.rb:
>>
>> > @@ -25,12 +25,22 @@ def push(obj)
>> >    end
>> >    alias_method :<<, :push
>> >
>> > -  def pop(timeout=0.5)
>> > -    deadline = Time.now + timeout
>> > +  def pop(connections_count, timeout = 0.5)
>>
>> Why would I need to pass a count to pop? That doesn't make a lot of
>> sense. That's a sign you need to refactor your impl.
>>
>> —
>> Reply to this email directly or view it on GitHub<https://github.com/mperham/connection_pool/pull/37/files#r6114312>
>> .
>>
>
>
>
> --
> Bruno Coelho
>



-- 
Bruno Coelho