filled in readme and parameterized tests