needs rspec though