Do you mean tests_api.py?  I don't see any 'c' tests.


On Tue, Jun 4, 2013 at 11:05 AM, seberg <notifications@github.com> wrote:

> In numpy/core/src/multiarray/common.c:
>
> > +/*
> > + * Stripped down version of PyObject_GetAttrString,
> > + * avoids lookups for None, tuple, and List objects,
> > + * and doesn't create a PyErr since this code ignores it.
> > + *
> > + * 'v' is the object to search for attribute.
> > + *
> > + * 'name' is the attribute to search for.
> > + *
> > + * Returns attribute value on success, 0 on failure.
> > + */
> > +PyObject *
> > +PyArray_GetAttrString_Lite(PyObject *v, char *name)
> > +{
> > +    PyTypeObject *tp = Py_TYPE(v);
> > +    if (tp==&PyList_Type || tp==&PyTuple_Type || v==Py_None) {
>
> It is scary. I just noticed that the last commit in this corner of numpy
> probably introduced a regression (the string stuff is difficult). There is
> basically not a single test for this I can find, so we *really* need some
> tests. And I think you should add at least some basic tests for the things
> that could in principle be affected here, i.e. for the buffer interface
> path here. The right place would probably be in
> numpy/core/tests/test_api.c creating a new class to add more tests later.
>
> I know it is annoying, but tests are often just as much work as the code
> itself... And if we have better tests we can maybe do real clean ups in the
> future.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/numpy/numpy/pull/3396/files#r4524693>
> .
>