#835, thanks for the reminder


On Thu, Dec 12, 2013 at 9:52 AM, zkasheff <notifications@github.com> wrote:

> In src/mongo/s/d_migrate.cpp:
>
> > @@ -1478,22 +1380,12 @@
> >              migrateFromStatus.done();
> >              timing.done(5);
> >
> > -            {
> > -                // 6.
> > -                OldDataCleanup c;
> > -                c.ns = ns;
> > -                c.min = min.getOwned();
> > -                c.max = max.getOwned();
> > -                c.shardKeyPattern = shardKeyPattern.getOwned();
> > -                // Vanilla MongoDB checks for cursors in the chunk, and if any exist, it starts a background thread that waits for those cursors to leave before doing the delete.
> > -                // We have MVCC so we don't need to wait, we can just do the delete.
> > -                // TODO: get rid of the OldDataCleanup class and just do the removeRange right here.
> > -                c.doRemove();
>
> Do we have a ticket to investigate the impact of garbage on these chunk
> migrations? It's possible that a range delete will leave a bunch of garbage
> that rarely gets cleaned up, because the nodes no longer get accessed.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Tokutek/mongo/pull/832/files#r8301211>
> .
>



-- 
Cheers,
Leif