Vote:    _(...)   that is the openstack way for internationalization/language support

From: John Wood [mailto:notifications@github.com]
Sent: Wednesday, June 05, 2013 1:44 PM
To: cloudkeep/python-barbicanclient
Subject: Re: [python-barbicanclient] Add logging and an initial test file (#5)


In barbicanclient/client.py:

>          order_dict = {'secret': {}}

>          order_dict['secret']['name'] = name

>          order_dict['secret']['mime_type'] = mime_type

>          order_dict['secret']['algorithm'] = algorithm

>          order_dict['secret']['bit_length'] = bit_length

>          order_dict['secret']['cypher_type'] = cypher_type

> +        for k in order_dict['secret'].keys():

> +            if order_dict['secret'][k] is None:

> +                order_dict['secret'].pop(k)

> +        LOG.debug("Request body: {}".format(order_dict['secret']))

Probably should '_(....)' all the 'debug' strings, or else change some things, like 'Creating ...' to 'info' LOG types.
What do you think Douglas?

—
Reply to this email directly or view it on GitHub<https://github.com/cloudkeep/python-barbicanclient/pull/5/files#r4555329>.