Yes. That coding style is generally considered best practice in Ruby. Also this functionality lacks unit tests. :)