Yes Justin that did it thanks!

So, from my point of view, the only big change that we will need now is related to the +/- adjuster. As you may have seen, i had to comment out all code of my PlusMinusAdjuster.js
https://github.com/chrispetsos/prefsEditors/blob/master/src/shared/adjusters/js/PlusMinusAdjuster.js
This had to be done after merging for a number of reasons which have to do with the fact that many members had to be renamed in order not to have merging conflicts. For example, that code operates on "that.model.value" while now every preference has its own name e.g. "model.magnification". Same stands for previews etc. That used to work because each adjuster was a separate component, but now we merge everything in a single component. How can this be reused after merging? Perhaps Alex's version is better at that? What do you think? I the meantime, i had an email from Alex a couple of days ago stating,

"Also, I suggest we use your way of combining adjusters, rather than 
grade merging like in Speak Text (the grade merging was an attempt for 
something that eventually even Justin and Antranig were unable to 
resolve)."

I'm confused... Even if we cannot currently go for reusable code, under the pressing timeframe we have, what would you suggest? Maybe duplicate all code and only rename the needed parts? I know though that you are against letting duplicate code in repo, and you are correct doing that. Don't know... any thoughts?

Date: Wed, 23 Oct 2013 06:08:50 -0700
From: notifications@github.com
To: prefsEditors@noreply.github.com
CC: chrispetsos@msn.com
Subject: Re: [prefsEditors] GPII-187, GPII-188, GPII-225, GPII-227 contributions (#7)

In src/pmt/js/PMT.js:

> +                },
> +                resetButtonText: {
> +                    expander: {
> +                        func: "gpii.uiOptions.pmt.lookupMsg",
> +                        args: ["{uiOptionsLoader}.msgBundle", "resetButtonText"]
> +                    }
> +                },
> +                cancelButtonText: {
> +                    expander: {
> +                        func: "gpii.uiOptions.pmt.lookupMsg",
> +                        args: ["{uiOptionsLoader}.msgBundle", "cancelButtonText"]
> +                    }
> +                }
> +            },
> +            components: {
> +                increaseSizeExtraAdjustersComponent: {

Because the option takes in a function as opposed to a name, you have to declare that function before it is used. Basically, just move the code for gpii.uiOptions.panels.arrayMergePolicy to the top of the file and things should work.


—
Reply to this email directly or view it on GitHub.