all attrs updated and added,  need to test