upload function commit