simplify CStarmap::m_BadMapModifiers related code

This was a double** ... = new ... due to the change to variable map sizes.
Changed to std::vector.
cppcheck didn't like the fact of allocation with new but no copy
constructor present.
cppcheck: intialize struct members
cppcheck: reduce variable scope
cppcheck: reduce variable scopes
cppcheck: reduce variable scope
cppcheck: reduce variable scope
cppcheck: reduce variable scopes
cppcheck: reduce variable scopes