host-deploy: cleanup: A class's finalize() method should have protected access, not public.

Change-Id: Iee1ad0b56b6e991dd54027c7be8282703c494474
Signed-off-by: Alon Bar-Lev <alonbl@redhat.com>
host-deploy: cleanup: Incorrect lazy initialization of static field VdsDeploy.s_deployPackage

Change-Id: Iade6cbfc53e3736600c587d6006bbac41a3c0ff3
Signed-off-by: Alon Bar-Lev <alonbl@redhat.com>
host-deploy: cleanup: Exception is caught when Exception is not thrown

Change-Id: I46993b678b8c1a1e12c8fe433d8d081657dba5b4
Signed-off-by: Alon Bar-Lev <alonbl@redhat.com>
host-deploy: cleanup: Redundant nullcheck of vdsByUniqueId

Change-Id: Idd6454026bfa210c382d1e20d5c69dec7d11c104
Signed-off-by: Alon Bar-Lev <alonbl@redhat.com>
pki: cleanup: the method name SignCertificateRequest doesn't start with a lower case letter

Change-Id: I6a5677d644f000254be5c8d5bdae4ba6478b8f25
Signed-off-by: Alon Bar-Lev <alonbl@redhat.com>
pki: cleanup: Found reliance on default encoding

Change-Id: I181c9b3e26c5b941fe368b3287a7486b6b8f91e1
Signed-off-by: Alon Bar-Lev <alonbl@redhat.com>
pki: cleanup: Format string should use %n rather than \n

Workaround to quiet findbugs... we do need \n...

Change-Id: I6ff7707618243d0d0989819571e425580667b5a2
Signed-off-by: Alon Bar-Lev <alonbl@redhat.com>
host-deploy: cleanup: remove unused VdsInstallStages

Change-Id: Ibeecb987720428dd0bd515884dde8e6a198159a2
Signed-off-by: Alon Bar-Lev <alonbl@redhat.com>
host-deploy: cleanup: favor Charset.forName() over plain string

Change-Id: Ifa209cebf9efa5dc6c8e3f50447c9af25fcf9c2f
Signed-off-by: Alon Bar-Lev <alonbl@redhat.com>
pki: cleanup: favor Charset.forName() over plain string

Change-Id: Id61cad58356820a73683666235d328a72582486b
Signed-off-by: Alon Bar-Lev <alonbl@redhat.com>
core: Remove unused IsStoragePoolWithSameNameExist

Removed the unused IsStoragePoolWithSameNameExistQuery.
This patch removes the following:
1. The unused IsStoragePoolWithSameNameExistQuery class.
2. The IsStoragePoolWithSameNameExistParameters class only used by the
   aforementioned query class.
3. The IsStoragePoolWithSameNameExistQuery constant in VdcQueryType
   corresponding to the removed class.

Change-Id: I08bba52c8795bba0535d4651c0b6532dd4d523c9
Signed-off-by: Allon Mureinik <amureini@redhat.com>
core: Remove GetAllIdsFromExportDomainQuery

GetAllIdsFromExportDomainQuery is not used anywhere in the code, and
hence should be removed.

This patch removes the following:
1. The GetAllIdsFromExportDomainQuery class
2. The GetAllIdsFromExportDomain constant representing it in
   VdcQueryType
3. The GetVmsListVDSCommand class which was only used by
   this query.
4. The GetVmsList constant representing it in
   VDSCommandType.
5. The getVmsList(String, String)  method in
   IIrsServer/IrsServerWrapper, which was only used
   by GetVmsListVDSCommand.
6. The GetVmsListReturnForXmlRpc class which was only used by
   GetVmsListVDSCommand.

Change-Id: Id6c384ccbb317f67afb4d0fc13373dd6c7671f93
Signed-off-by: Allon Mureinik <amureini@redhat.com>
core: Remove IsVdsWithSameNameExist

IsVdsWithSameNameExistQuery is not used anywhere in
the code, and hence should be removed.

This patch removes the following:
1. The IsVdsWithSameNameExistQuery class
2. The IsVdsWithSameNameExist constant representing
   it in VdcQueryType
3. The IsVdsWithSameNameExistParameters class which
   was only used by the removed query class.
3. The getByVdsName(String) method in VdsStaticDAO
   (which was only used by the query), its implementation, and its
   test.
4. The GetVdsStaticByVdsNam stored procedure
   that was only used by the said DAO function.

Change-Id: I676cca49a2cc62c7b0716589ee26d2bcffd3cbb7
Signed-off-by: Allon Mureinik <amureini@redhat.com>
core: Removing CreateComputerAccount command

Change-Id: I6224722615cf61b23a35f3eda6db802e5dc1a6bd
Signed-off-by: Yair Zaslavsky <yzaslavs@redhat.com>