A slightly modified patch from Sumit Pandit for "Additional Validation for Password  : Make password pattern driven" https://issues.apache.org/jira/browse/OFBIZ-4958

Provides an additional validation for password  with following capability to the system:

Admin can enable/disable pattern based password capability of system. Configuration will reside in security.property file.
 To enable : security.login.password.pattern.enable=true
 To disable: security.login.password.pattern.enable=false

Admin is flexible to provide his pattern string by making pattern more/less restrictive as per system requirement. Configuration will reside in security.property file.
 Example: security.login.password.pattern=^.*(?=. {5,})(?=.[a-zA-Z])(?=.[!@#$%^&*]).*$

Admin can provide custom error message string which will display to end user if wrong password is entered. Configuration will reside in security.properity file.

jleroux: I quickly handled the error message localisation for the OOTB case. It's more complicated when the pattern gets complex...


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1418996 13f79535-47bb-0310-9956-ffa450edef68
Fixes "Flatgrey visual theme does not work"  https://issues.apache.org/jira/browse/OFBIZ-5096 reported by Wai and pointed out by Adrian in dev ML

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1420019 13f79535-47bb-0310-9956-ffa450edef68
make reserved hotel rooms appear on the fixed asset calendar

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1420569 13f79535-47bb-0310-9956-ffa450edef68
At Adrian and Adam's demand allow to use cache here, use default constructor
Also refactored things a bit: 
* uses getPropertyAsBoolean
* set default property values

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1421651 13f79535-47bb-0310-9956-ffa450edef68
Fixes "XML file containg Byte order mark" reported by Youssef Khaye at https://issues.apache.org/jira/browse/OFBIZ-5099

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1421662 13f79535-47bb-0310-9956-ffa450edef68
Adrian remarked there was no need to use class fields


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1421738 13f79535-47bb-0310-9956-ffa450edef68
Removes the instance of the static utility class 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1422099 13f79535-47bb-0310-9956-ffa450edef68
Closes <<TYPO in service name "udpateWebSitePathAlias">> reported by Atul Vani https://issues.apache.org/jira/browse/OFBIZ-5101

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1422101 13f79535-47bb-0310-9956-ffa450edef68
A patch from Naofumi Fukue for "javascript error in hidden form" https://issues.apache.org/jira/browse/OFBIZ-5098

HtmlMenuRenderer generates like bellow form tags. It generates double target="_BLANK" , then cause javascript error.

<li><form method="post" action="/ar/control/invoice.pdf" target="_BLANK" name="InvoiceSubTabBar_pdf_LF_8"><input name="invoiceId" value="8010" type="hidden"/></form><a target="_BLANK" href="javascript:document.InvoiceSubTabBar_pdf_LF_8.submit()">PDF</a></li>

document.InvoiceSubTabBar_pdf_LF_8 is undefined @ javascript:document.InvoiceSubTabBar_pdf_LF_8.submit()

jleroux: to reproduce 

For example, edit applications/accounting/webapp/accounting/WEB-INF/controller.xml like this.

<request-map uri="invoice.pdf">
<security https="true" auth="true"/>
<event name="test" type="java" path="org.ofbiz.webapp.event.TestEvent" invoke="test"/> <= add this
<response name="success" type="view" value="InvoicePDF"/>
</request-map>

And in invoice screen, click 'PDF' button. Exist or not exist above line, generated html is different.

As is 
~event: PDF rendered
<li><a target="_BLANK" href="/ar/control/invoice.pdf?invoiceId=8010">PDF</a></li>
event:  PDF not rendered
<li><form method="post" action="/ar/control/invoice.pdf" target="_BLANK" name="InvoiceSubTabBar_pdf_LF_8"><input name="invoiceId" value="8010" type="hidden"/></form><a target="_BLANK" href="javascript:document.InvoiceSubTabBar_pdf_LF_8.submit()">PDF</a></li>

patched
~event: PDF rendered
<li><a target="_BLANK" href="/ar/control/invoice.pdf?invoiceId=8010">PDF</a></li>
event: PDF rendered
<li><form method="post" action="/ar/control/invoice.pdf" target="_BLANK" name="InvoiceSubTabBar_pdf_LF_8"><input name="invoiceId" value="8010" type="hidden"/></form><a href="javascript:document.InvoiceSubTabBar_pdf_LF_8.submit()">PDF</a></li>


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1422207 13f79535-47bb-0310-9956-ffa450edef68
A patch from Shi Jinghai for "Support MySQL and Postgres's LIMIT and OFFSET options" https://issues.apache.org/jira/browse/OFBIZ-4346

Change the existing code to support the different syntax variations, and add an attribute to the datasource element in the entityengine.xml file so that the proper variation can be chosen for each database.
Inspired by Moqui code. Test successful


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1422221 13f79535-47bb-0310-9956-ffa450edef68
Moved ebay demo data from ecommerce to the ebay component

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1422684 13f79535-47bb-0310-9956-ffa450edef68
Commented out testLimitOffsetOptions() because it makes the framework dependent on the content component.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1422796 13f79535-47bb-0310-9956-ffa450edef68
A patch from Carsten Schinzer for "CheckoutScripts not adapted after ShoppingCart.setShipmentMethodTypdeId" https://issues.apache.org/jira/browse/OFBIZ-5102

The CustomerEvent scripts do not yet account for the fact that the method takes two parameters after a code change on ShoppingCart:
- int shipGroupIndex and
- String shipmentMethodTypeId
instead of the latter String only in earlier versions.

Minilang Script calls to setShipmentMethodTypeId with a single String Parameter need to be changed.
They now must call setAllShipmentMethodTypeId. This method has been introduced with rev. 1407116.

jleroux: so this was not covered by unit tests, too bad but I don't think I will get enough time to write them :/


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1422814 13f79535-47bb-0310-9956-ffa450edef68
This was causing duplicates in language selection in Label Manager, thanks to Jinghai's help

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1423117 13f79535-47bb-0310-9956-ffa450edef68
Fix 3 missing English labels

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1423120 13f79535-47bb-0310-9956-ffa450edef68
missing fk-name for CountryAddressFormat entity, causing error messages when starting OFBiz

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1425146 13f79535-47bb-0310-9956-ffa450edef68
A patch from Carsten Schinzer for "non facet valid method name in OrderServices.xml#orderSequence-enforced" https://issues.apache.org/jira/browse/OFBIZ-5106

Error message in the error.log is as follows:
XmlFileLoader: File file:/usr/local/ofbiz-tr-mt12.5/applications/order/script/org/ofbiz/order/order/OrderServices.xml process error. Line: 530. Error message: cvc-pattern-valid: Value 'orderSequence-enforced' is not facet-valid with respect to pattern '[a-zA-Z_]{1}[a-zA-Z0-9_$.]+' for type 'javaClassName'.

Changes all occurrencies of 'orderSequence-enforced' to 'orderSequence_enforced' as only underscore dashed are allowed by the cvc pattern.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1425155 13f79535-47bb-0310-9956-ffa450edef68
Fix a bug reported by Mark Schneider on user ML:
>It looks like a wrong credit card number leads to the following error message in UI (tested with one-page checkout):
>        # ---
>        ... (INSERT on table 'ORDER_CONTACT_MECH' caused a violation of foreign key constraint 'ORDER_CMECH_CM' for key (10005). ...
>
>        I would rather expect an error message like "invalid credit cartd number" instead.

jleroux: the bug was actually double 

1st: a last issue related to https://issues.apache.org/jira/browse/OFBIZ-5102 after https://issues.apache.org/jira/browse/OFBIZ-3883
2nd: the cardNumber was missing a creditcard class (jquery.validate.js messages)


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1425452 13f79535-47bb-0310-9956-ffa450edef68
This was wrong since r759871 (reversed test)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1425662 13f79535-47bb-0310-9956-ffa450edef68
Fix "Editing of product suppliers is not working for the Germany locale" https://issues.apache.org/jira/browse/OFBIZ-4769

Thanks to Christian, Paul, Deepak and Adrian


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1425716 13f79535-47bb-0310-9956-ffa450edef68