Revert "Revert "Merge branch 'hkenney-ticket/master/2157_remove_facts_dot_d'""

This reverts commit d3e30bcdc64964bba82e05e5409c38faa7f2b700.
(#14422) Update README to include the bug tracker URL.

As reported, it is indeed difficult to navigate directly to the correct
part of Redmine for a particular sub-project. This commit puts the
issue tracker URL front and center.
Merge pull request #90 from ahpook/14422_update_readme

(#14422) Update README to include the bug tracker URL.
Merge branch '3.x'

* 3.x:
  (#14422) Update README to include the bug tracker URL.
Merge branch '3.x'

* 3.x:
  (Maint) Fix mis-use of rvalue functions as statements
  Add .rspec file to repo root
Merge branch '3.x'

* 3.x:
  Disable tests that fail on 2.6.x due to #15912
Fix some logical inconsistencies in README
Merge pull request #93 from ptman/patch-1

Fix some logical inconsistencies in README
Merge branch '3.x'

* 3.x:
  (Maint) Remove core function documentation from README

Conflicts:
	README.markdown
Add PE facts to stdlib

As many PE modules have PE specific functionality, but are deployed to all
nodes, including FOSS nodes, it is valuable to be able to selectively enable
those PE specific functions. These facts allow modules to use the is_pe fact to
determine whether the module should be used or not. The facts include is_pe,
pe_version, pe_major_version, pe_minor_version, and pe_patch_version. For PE
2.6.0 those facts would have values true, 2.6.0, 2, 6, and 0, respectively.
Add spec tests for pe_version facts

This commit adds some basic spec tests for the pe_version facts. There are
basic postitive and negative cases.
(maint) Clear all facts before each example

Without this patch example groups must explicitly call `Facter.clear` to
clear any cached values between examples.  This is a problem because
this behavior is not the concern of the example groups, the behavior is
the concern of the spec_helper or whatever facility we have in place to
initialize the system for testing.

This patch fixes the problem by duplicating the logic in the Facter
spec_helper to ensure facts are cleared out before each example.

This patch requires the example groups to explicitly load the facts they
require if the fact name does not match the filename.
Prevent undefined method `split' for nil:NilClass with pe_foo_version facts

Without this patch the pe_major_version, pe_minor_version, and
pe_patch_version facts directly depend on the pe_version fact in a
manner that calls split directly on the return value.

This is a problem because Fact values are not always guaranteed to
return strings, or objects that respond to split.  This patch is a
defensive measure to ensure we're always calling the split method on a
string object.

If the Fact returns nil, this will be converted to an empty string
responding to split.
Merge branch 'haus-add_pe_facts_to_stdlib' into 2.4.x

* haus-add_pe_facts_to_stdlib:
  Prevent undefined method `split' for nil:NilClass with pe_foo_version facts
  (maint) Clear all facts before each example
  Add spec tests for pe_version facts
  Add PE facts to stdlib
Merge branch '2.4.x'

* 2.4.x:
  Prevent undefined method `split' for nil:NilClass with pe_foo_version facts
  (maint) Clear all facts before each example
  Add spec tests for pe_version facts
  Add PE facts to stdlib

Conflicts:
	spec/spec_helper.rb
Revert "Merge branch 'haus-add_pe_facts_to_stdlib' into 2.4.x"

This reverts commit 74e6411157b8df1af9a24c17971e3236f3096529, reversing
changes made to 417d219aa6e42f2a16af42c98aa063fc1d9d2ecd.

Here's why:

Actually... I just screwed this up.

I merged this new fact into 2.4.x but it's not fixing any bug. It's adding a
new fact, so this should go into master and we should release 2.5 since this is
new, backwards-compatible functionality.
Merge branch '2.4.x'

* 2.4.x:
  Revert "Merge branch 'haus-add_pe_facts_to_stdlib' into 2.4.x"
Revert "Revert "Merge branch 'haus-add_pe_facts_to_stdlib' into 2.4.x""

This reverts commit d6d23b495cda0e154b4e73982acc43e586564c0e.

Why?  Because this change set should actually be in master and our
merge-up process reverted the change set in master when I reverted from
2.4.x.

This patch reverts the revert, restoring the original change set.
Revert "Revert "Merge branch 'haus-add_pe_facts_to_stdlib' into 2.4.x""

This reverts commit d6d23b495cda0e154b4e73982acc43e586564c0e.

This backwards-compatible additional functionality is targeted at the
next minor release.  There are already backwards-incompatible changes in
the master branch so we need to establish a new minor branch.
Merge branch '2.5.x'

* 2.5.x:
  Revert "Revert "Merge branch 'haus-add_pe_facts_to_stdlib' into 2.4.x""