afaik sonar will crash with duplicate source exception. in the current
implementation this will not be seen since it just throws the exception way
along with the results (but i need to double check this)


On Fri, Apr 5, 2013 at 9:10 AM, wenns <notifications@github.com> wrote:

> In
> sonar-cxx-plugin/src/test/resources/org/sonar/plugins/cxx/xunit/project_finding_sources/tests2/Test4.hh:
>
> > @@ -0,0 +1,5 @@
> > +namespace ns{
> > +    class TestClass4{
> > +        void test1();
> > +    };
> > +};
>
> On 04/04/2013 06:04 PM, Jorge Costa wrote: In
> sonar-cxx-plugin/src/test/resources/org/sonar/plugins/cxx/xunit/project_finding_sources/tests2/Test4.hh:
> > @@ -0,0 +1,5 @@ > +namespace ns{ > + class TestClass4{ > + void test1();
> > + }; > +}; you did not include a case where two or more test classes are
> included in the same file.
> Yep, such one should be added.
>  This will likely result in the second class test results not being
> imported at all into sonar. My pull request would still import the test
> results, however it would import a virtual file along with it.
> Why not assign the same source to both tests? Does Sonar prevent it?
>  This use case, would result in a new Rule. One test class per file.
> Maybe.
> … <#13dd8d1625df26dc_>
>  Which was also implemented in a older pull request. — Reply to this email
> directly or view it on GitHub <
> https://github.com/SonarCommunity/sonar-cxx/pull/22/files#r3657785>.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/SonarCommunity/sonar-cxx/pull/22/files#r3668502>
> .
>