I am working on cleaning things up a bit. And to see if I can make a rule rather than using super type test class. Maybe wait until I finish before reviewing. 

Patrick Huang 
Senior Software Engineer 
Engineering - Internationalisation 
Red Hat 

----- Original Message -----

> From: "David Mason" <notifications@github.com>
> To: "zanata/zanata-server" <zanata-server@noreply.github.com>
> Sent: Tuesday, October 8, 2013 11:55:48 AM
> Subject: Re: [zanata-server] WIP: Screenshot via Test Listener integration
> (#213)

> In functional-test/src/main/java/org/zanata/util/TestEventListener.java:
> > +            log.info("[Screenshot]: Prevented by Alert");
> > +            return;
> > +        }
> > +        createScreenshot("_click");
> > +    }
> > +
> > +    @Override
> > +    public void onException(Throwable throwable, WebDriver driver) {
> > +        createScreenshot("_exc");
> > +    }
> > +
> > +    /*
> > +     * Unused interface functions
> > +     */
> > +    @Override
> > +    public void afterChangeValueOf(WebElement element, WebDriver driver) {

> To keep things clean, you could add an abstract class that implements the
> interface and has all these empty implementations.

> —
> Reply to this email directly or view it on GitHub .