James,

If I am understanding correctly, are you suggesting that I should look into
adding ROUND, CEIL and FLOOR functions to our language support? And then on
java side, have RoundFunction.java, CeilingFunction.java,
FloorFunction.java as abstract with concrete implementations for specific
data types?


On Fri, Nov 1, 2013 at 9:08 PM, James Taylor <notifications@github.com>wrote:

> In
> src/test/java/com/salesforce/phoenix/expression/CoerceExpressionTest.java:
>
> > @@ -126,4 +128,76 @@ public void testCoerceExpressionSupportsCoercingAllPDataTypesToBinary() throws E
> >  		}
> >      }
> >  	
> > +	@Test
>
> These are all good tests, but lets fold them all into the ROUND function
> so we can expose them directly as a built-in function as well. Just have
> RoundFunction be an abstract function with the type specific ones being the
> concrete derived classes. All the better if you can fold the CEIL, FLOOR
> functions into this for consistency as well.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/forcedotcom/phoenix/pull/516/files#r7386739>
> .
>