whats the correct type here?