Ya matei here it actually goes the other way here (the default for the
timeout is a multiplier of the heartbeat) that's why the heartbeat was set
in my PR. But I'll just reverse it to be like you said.


On Tue, Jun 4, 2013 at 6:34 PM, Patrick Wendell <pwendell@gmail.com> wrote:

> ah I see, that's strictly better. I'll do that and submit here and also to
> 0.7.
>
>
> On Tue, Jun 4, 2013 at 6:32 PM, shivaram <notifications@github.com> wrote:
>
>> In core/src/main/scala/spark/storage/BlockManager.scala:
>>
>> > @@ -950,7 +950,7 @@ object BlockManager extends Logging {
>> >    }
>> >
>> >    def getHeartBeatFrequencyFromSystemProperties: Long =
>>
>> Afaik, this is the frequency with which heart beat messages are sent -- I
>> think there is another flag spark.storage.blockManagerSlaveTimeoutMswhich is by default 3
>> * heartBeatFrequency. One thing we could consider is having frequent
>> hearbeats (say 10s) but detecting a failure only when 10 heartbeats are
>> missed.
>>
>> —
>> Reply to this email directly or view it on GitHub<https://github.com/mesos/spark/pull/639/files#r4535124>
>> .
>>
>
>