If it weren't constant, I might care?

On Tuesday, July 23, 2013, alierak wrote:

> In bin/upgrading/update-db.pl:
>
> > @@ -170,7 +170,15 @@
> >
> >      foreach my $t (keys %table_unknown)
> >      {
> > -        print "# Warning: unknown live table: $t\n";
> > +        # dreamhacks use the same database for website and mogilefs
> > +        my @mogile_tables = qw( domain class file tempfile file_to_delete
> > +                                unreachable_fids file_on file_on_corrupt
> > +                                host device server_settings file_to_replicate
> > +                                file_to_delete_later fsck_log file_to_queue
> > +                                file_to_delete2 checksum note error job
> > +                                funcmap exitstatus );
>
> Not that this is a performance-critical section here, but it looks like
> you're going to create a new constant "my" array on every iteration of this
> loop.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/dreamwidth/dw-free/pull/527/files#r5347367>
> .
>