I imported the checkstyle config and applied the formatting to the 3 files
in question and find a lot of formatting changes in the 3 files.  So I
tried running mvn checkstyle:checkstyle on the original file and found a
lot of errors.  Then I ran it against the files that I modified, and find
the same errors (ex: in AbstractPatternDefnResolver, Method
'resolveDefinition' is not designed for extension - needs to be abstract,
final or empty.).

So it appears that the original code doesn't even match the checkstyle
configs itself.  However, what I find the strangest is that mvn
checkstyle:checkstyle complains that lines are longer than 80 chars, even
though the config file specifes that the max length is 120chars ("Line is
longer than 80 characters (found 114).").

I'm not quite sure what I should do.  Should I just apply the checkstyle
formatting to the files and commit them or leave them as they currently are?

Thanks,

Eric



On Sun, Nov 3, 2013 at 5:31 AM, mck <notifications@github.com> wrote:

> In
> tiles-core/src/main/java/org/apache/tiles/definition/pattern/AbstractPatternDefinitionResolver.java:
>
> > @@ -106,4 +106,16 @@ private Definition searchAndResolveDefinition(
> >
> >          return d;
> >      }
> > +
> > +
> > +    /**
> > +     * Used to clear all entries in the localePatternPaths for a specific locale.  Necessary when reloading definition files
> > +     * to ensure that the list is cleared first
> > +     * @param customizationKey
> > +     */
> > +    @Override
> > +	public void clearPatternPaths( T customizationKey ){
> > +    	if( localePatternPaths != null && localePatternPaths.get(customizationKey) != null )
>
> Tiles uses a checkstyle configuration found at
> http://svn.apache.org/repos/asf/tiles/maven/trunk/build/tiles_checks_v5.xml
>
> This is configured into the parent pom.xml so you can run mvn
> checkstyle:checkstyle.
> The checkstyle report for the project can be found for each tiles project,
> eg
> http://tiles.apache.org/framework/checkstyle-aggregate.html
> http://tiles.apache.org/tiles-request/checkstyle-aggregate.html
> http://tiles.apache.org/tiles-autotag/checkstyle-aggregate.html
>
> I presume Eclipse's editor can import a project's checkstyle configuration
> easily enough?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/apache/tiles/pull/2/files#r7390325>
> .
>