Also, forgot to clarify that i've tried these after uncommenting this block,

https://github.com/chrispetsos/prefsEditors/blob/master/src/shared/adjusters/js/IncreaseSizeAdjuster.js#L177-L189

From: chrispetsos@msn.com
To: reply@reply.github.com
CC: obara.justin@gmail.com
Subject: RE: [prefsEditors] GPII-187, GPII-188, GPII-225, GPII-227 contributions (#7)
Date: Wed, 23 Oct 2013 11:26:29 +0300




Well, tried to employ this array merging technique, but it doesn't work. Added these parts,
https://github.com/chrispetsos/prefsEditors/commit/bec24cac3b277788f60a07e5618dbca79e5f8cb9
but it seems that the "gpii.uiOptions.panels.arrayMergePolicy" function is never invoked.
I also tried to change both magnifierFollows and magnifierPosition repeating selectors to something like,

        repeatingSelectors: ["magnifierFollowsRow", "magnifierPositionRow"],

but again it didn't work. In both cases only magnifierFollows is working.

Date: Tue, 22 Oct 2013 09:12:43 -0700
From: notifications@github.com
To: prefsEditors@noreply.github.com
CC: chrispetsos@msn.com
Subject: Re: [prefsEditors] GPII-187, GPII-188, GPII-225, GPII-227 contributions (#7)

In src/pmt/js/PMT.js:

> +                },
> +                resetButtonText: {
> +                    expander: {
> +                        func: "gpii.uiOptions.pmt.lookupMsg",
> +                        args: ["{uiOptionsLoader}.msgBundle", "resetButtonText"]
> +                    }
> +                },
> +                cancelButtonText: {
> +                    expander: {
> +                        func: "gpii.uiOptions.pmt.lookupMsg",
> +                        args: ["{uiOptionsLoader}.msgBundle", "cancelButtonText"]
> +                    }
> +                }
> +            },
> +            components: {
> +                increaseSizeExtraAdjustersComponent: {

@chrispetsos we're probably a day or two away from getting our compositePanel ready for code review in Infusion, but we'll still need to update the prefsEditor repo with infusion, and that will bring a huge change to naming amongst other things. We've moved the bulk of the uiOptions code to be a Preference Framework and renamed most functions around this. 


Anyways, to fix your immediate issue of the rendering of the magnifierPosition adjuster the problem was that the repeatingSelectors were not being merged the way you thought. Arrays, by default, are replaced. Luckily Yura was able to help me spot this one. So you can either just redefine the repeatingSelectors option with all of the repeating selectors, or you can add a new mergePolicy.


    gpii.uiOptions.panels.arrayMergePolicy = function (target, source) {
        target = fluid.makeArray(target);
        source = fluid.makeArray(source);
        fluid.each(source, function (selector) {
            if($.inArray(selector, target) < 0) {
                target.push(selector);
            }
        });
        return target;
    };

    fluid.defaults("gpii.uiOptions.panels.increaseSize", {
        ...
        repeatingSelectors: gpii.uiOptions.panels.arrayMergePolicy
        ...
    })


Also, in looking into this, it seems that you have some unneeded markup. Things like:


<div class="fl-crossout"></div>


You should try to clean up the markup as much as possible, removing elements and classes that aren't needed/used.


—
Reply to this email directly or view it on GitHub.