Hi Ingo

Thank you for the feedback.  I hope I have done it correctly.

https://github.com/silverstripe/silverstripe-framework/pull/2319/files#r5868307

Nicolaas


On 21 August 2013 01:40, Ingo Schommer <notifications@github.com> wrote:

> In core/Config.php:
>
> > @@ -165,11 +165,12 @@ protected static function get_value_type($val) {
> >  	 *
> >  	 * @throws UnexpectedValueException
> >  	 */
> > -	protected static function type_mismatch() {
> > +	protected static function type_mismatch($debugValue1 = null, $debugValue2 = null) {
>
> Can you please add phpdoc for the two params?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/silverstripe/silverstripe-framework/pull/2319/files#r5868352>
> .
>



-- 
Nicolaas Thiemen Francken
Sunny Side Up Ltd  {
  Skype: atyourservicehour
  Phone: +64 4 889 2773
  Emergencies: 0221697577
  nt@sunnysideup.co.nz
  http://www.sunnysideup.co.nz
}