fix convert and promotion_rule