complete fromxml generation