Oh we do, I wrote it similarly for the tfidf weighting scheme.And olly has
already seen this patch too.



On Sat, Jun 22, 2013 at 10:05 PM, Dan Colish <notifications@github.com>wrote:

> In xapian-applications/omega/weight.cc:
>
> > @@ -128,6 +128,17 @@
> >  	}
> >  #endif
> >
> > +        if (startswith(scheme, "dph")) {
> > +	    const char *p = scheme.c_str() + 3;
> > +	    if (*p == '\0') {
> > +		enq.set_weighting_scheme(Xapian::DPHWeight());
> > +		return;
> > +	    }
> > +	    if (C_isspace((unsigned char)*p)) {
>
> I'm not sure we strip trailing whitespace when parsing the omegascript
> line here. It would be good to verify
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/xapian/xapian/pull/12/files#r4831260>
> .
>