We need this because without it, I lost a day's work when setting the
reportFolder parameter to my project root.

Its default behavior was to delete my entire project and its `.git`
directory history.

The safer behavior is to not delete. If someone set the reportFolder to
`~/`, they could delete their entire home directory!

---
Arjan

Typos by iPhone.

On Aug 9, 2013, at 2:34 PM, Pranav Parikh <notifications@github.com> wrote:

In lib/util/arrowsetup.js:

>              targetFolderPath =  path.resolve(global.workingDirectory, 'arrow-target');
>          }
>
> -        // Cleanup report folder if keepTestReport set to false or undefined
> -        if (this.argv.keepTestReport === undefined || false === this.argv.keepTestReport) {
> +        // Nuke target folder if keepTestReport set to false
> +        if (false === this.argv.keepTestReport) {

Why do we need this change ? In this case, users will always need to
specify keepTestReport=false to cleanup the reports from previous run.

—
Reply to this email directly or view it on
GitHub<https://github.com/yahoo/arrow/pull/116/files#r5694110>
.