this method needs attributes